adodb, branch v5.22.5adodb PHP Database Abstraction Layer
https://git.rdm1.uk/adodb/.git/atom?h=v5.22.52023-04-03T21:41:29ZBump version to 5.22.52023-04-03T21:41:29ZDamien Regaddregad@mantisbt.org2023-04-03T21:41:29Zurn:sha1:bacd08a8232b6d941b9902f02d323f53de81fafeUpdate Changelog2023-04-03T21:40:38ZDamien Regaddregad@mantisbt.org2023-04-03T21:40:33Zurn:sha1:9a03efe392cda2d098dd55b2e6aff79a5061fe35Fix exception when executing empty SQL on PHP 82023-04-03T21:33:49ZDamien Regaddregad@mantisbt.org2023-04-03T21:31:18Zurn:sha1:577c9adfeeb1eb35f241ef168f22715b878c3424
When calling execute() with an empty SQL query on MySQL, PHP throws an
Exception:
ValueError: mysqli_query(): Argument #2 ($query) cannot be empty
We now check that $sql is not empty, and if it is just return false.
Fixes #945
Back-ported from commit 8c57976eaf2f4cf9a71cc7fb88edb1d7b90b00ce.
# Conflicts:
# drivers/adodb-mysqli.inc.php
Remove useless variables and comments2023-03-25T21:06:33ZDamien Regaddregad@mantisbt.org2023-03-25T21:06:33Zurn:sha1:87437cfe7a7ef237119b2dc1f59bddc51aac38f7Whitespace2023-03-25T21:04:03ZDamien Regaddregad@mantisbt.org2023-03-25T21:04:03Zurn:sha1:780fe662aed3a3bfc556df128e75dd60322629b4PHPDoc2023-03-25T21:01:29ZDamien Regaddregad@mantisbt.org2023-03-25T21:01:29Zurn:sha1:fc46c8da8f27175a59d468fe39e445941857fa00Move MySQL BINARY to expression right-hand side2023-03-25T12:58:15ZDamien Regaddregad@mantisbt.org2023-03-25T12:58:15Zurn:sha1:09748995a96586348715049be1706f09a57d7478
Having it on the left-hand side prevented usage of the index, so a full
table scan was performed with significant performance impact when a
large number of sessions are stored in the table.
Fixes #941
Fix inconsistent DB provider check in ADODB_Session2023-03-25T12:54:17ZDamien Regaddregad@mantisbt.org2023-03-25T12:54:17Zurn:sha1:46f1c61177bbd12ef681a50b1c3a7961e8ec3995
Introduce a new class property to store the database provider, populated
when opening the connection, and handling the PDO drivers specificities.
New isConnectionMysql() and isConnectionPostgres() methods are replacing
tests against $conn->dataProvider or ADODB_Session::driver(), ensuring
a consistent check of the database type.
Fixes #943
Fix invalid markdown in 5.20.16 changelog2023-03-20T17:14:38ZDamien Regaddregad@mantisbt.org2023-03-20T17:14:38Zurn:sha1:d2c47fff971d883096ed56cacd8957cb4a88c42cFix PHP warning in ADODB_postgres64::MetaIndexes()2023-03-20T17:11:42ZDamien Regaddregad@mantisbt.org2023-03-20T17:11:42Zurn:sha1:07ade94036c18c7c93dfe742abbeac99a6f2f09f
When calling the function on a table having an index on an expression
column, a PHP warning is thrown:
Undefined array key 0 in ./drivers/adodb-postgres64.inc.php on line 666
Fixes #940