adodb/adodb-memcache.lib.inc.php, branch v5.22.11-lscadodb PHP Database Abstraction Layer
https://git.rdm1.uk/adodb/.git/atom?h=v5.22.11-lsc2022-03-30T08:38:22Zmemcache: use default port in server controller template2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-29T15:03:00Zurn:sha1:4cd1639371db8aa4fa2cd700f6f9c4b168d5f5b6
Fixes #824
Remove unnecessary ternary operator2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-29T10:18:18Zurn:sha1:b6e4a57a16d87541ee134f9c1ab8a9d878a28236Remove references to 'key' option2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-29T10:17:43Zurn:sha1:7deaef7e75a956feeb7288e98850066afa405b48
This was introduced in f24142da4e2237e39c9a98d6de0b3665fcf95db9 (#676).
It is part of a future improvement to the Memcache library, that should
not have been merged into the 5.22 release [1].
[1]: https://github.com/ADOdb/ADOdb/pull/816#issuecomment-1076967876
Fix $memCacheCompress option ignored by memcached2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-22T09:42:45Zurn:sha1:03d288daba769c73acb1cf3d7126b06083f48744
- Use assignment instead of comparison operator
- Allow disabling compression
Fixes #823
Refactor: add new isLibMemcached() method2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-21T09:49:42Zurn:sha1:94e37d98eb958dbe832f7752a597d80c6e7f6183Memcached connection never adds server controllers2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-21T09:11:04Zurn:sha1:8c555c712e07162031e8fc48212d973563d569bb
When connecting to Memcached, the code checks for existing connections
and uses that if present.
Problem is that getServerList() returns an empty array when there are
none, so the is_array() test is always true and connect() returned true
without ever adding the configured server controllers.
Fixes #807
memcache: fix server controllers initialization2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-21T08:58:19Zurn:sha1:3e2d00be07d237b9ff47ed54aadcc7c3bc105cd6
Flawed logic caused the $serverControllers property to be set with an
incorrect structure when using the "new" memCacheHost format ('host'
would contain an array instead of the hostname/ip), leading to a
PHP Fatal error when adding the server:
Uncaught TypeError: Memcached::addServer(): Argument 1 ($host) must be
of type string, array given
Fixes #807
Fix PHPStorm warnings2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-20T12:02:37Zurn:sha1:16c738c2652ffa0b0602f052fdf72dfd183c63c0Remove duplicate/unused $memCacheLibrary property2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-20T11:59:52Zurn:sha1:5fe44f1f7847458654177cbeedd7be7d6bc7efcf
Both $memcacheLibrary and $memCacheLibrary properties were declared,
but only the former was being used.
PHPDoc2022-03-30T08:38:22ZDamien Regaddregad@mantisbt.org2022-03-20T11:57:51Zurn:sha1:5c0a3a6bca0cc87587b4d6307700fd69a1a460d9