sqlite: Fix SQLDate() method

ADOdb date/time library was removed in #970. Follow-up PR #1002 replaced
legacy adodb_date()/adodb_date2() calls through custom functions, by
native strftime().

That introduced a regression in SQLDate() behavior, as the date formats
changed from PHP-style to strftime (e.g. `Ymd` -> `%Y%m%d`).

This commit partially reverts 4700171afa6c5f939e8d04b079331e207dea22ca
and reintroduces the createFunction() call with a closure
providing behavior compatible with the legacy adodb_date2() function.

It also removes the now-useless test script that was added as part of
PR #1002.

1 files changed, 14 insertions, 14 deletions

diff --git a/drivers/adodb-sqlite3.inc.php b/drivers/adodb-sqlite3.inc.php
index e8fe433f..be4fac39 100644
--- a/drivers/adodb-sqlite3.inc.php
+++ b/drivers/adodb-sqlite3.inc.php
@@ -413,19 +413,7 @@ class ADODB_sqlite3 extends ADOConnection {
 		$fmt       = str_replace($fromChars,$toChars,$fmt);
 
 		$fmt = $this->qstr($fmt);
-		return ($col) ? "strftime($fmt,$col)" : "strftime($fmt)";
-	}
-
-	/**
-	 * Creates any custom functions for SQLite
-	 *
-	 * This function is a placeholder for creating custom SQLite functions.
-	 * Currently, it does not implement any custom functions.
-	 *
-	 * @return void
-	 */
-	function _createFunctions()
-	{
+		return $col ? "adodb_date($fmt,$col)" : "adodb_date($fmt)";
 	}
 
 	/**
@@ -446,7 +434,19 @@ class ADODB_sqlite3 extends ADOConnection {
 			$argHostname = $argDatabasename;
 		}
 		$this->_connectionID = new SQLite3($argHostname);
-		$this->_createFunctions();
+
+		// Register date conversion function for SQLDate() method
+		// Replaces the legacy adodb_date() functions removed in 5.23.0
+		$this->_connectionID->createFunction('adodb_date',
+			function (string $fmt, $date = null) : string {
+				if ($date === null || $date === false) {
+					return date($fmt);
+				}
+
+				// If it's an int then assume a Unix timestamp, otherwise convert it
+				return date($fmt, is_int($date) ? $date : strtotime($date));
+			}
+		);
 
 		return true;
 	}