sqlite3: Fix result-less SQL statements executed twice

The sqlite3 driver relies on SQLite3::query to execute the statement,
which returns an empty SQLite3Result while the ADOConnection::_Execute()
method expects true for handling of result-less queries. This causes the
query to be executed a second time when ADOdb initializes the recordset
for what it wrongly assumes to be a SELECT statement.

This also addresses the same behavior with the sqlite driver, but the
fix was not tested as I don't have a sqlite 2 setup available.

Fixes #99

2 files changed, 12 insertions, 2 deletions

diff --git a/drivers/adodb-sqlite.inc.php b/drivers/adodb-sqlite.inc.php
index f6a04502..9956c1ba 100644
--- a/drivers/adodb-sqlite.inc.php
+++ b/drivers/adodb-sqlite.inc.php
@@ -213,6 +213,11 @@ class ADODB_sqlite extends ADOConnection {
 		if (!$rez) {
 			$this->_errorNo = sqlite_last_error($this->_connectionID);
 		}
+		// If no data was returned, we don't need to create a real recordset
+		// Note: this code is untested, as I don't have a sqlite2 setup available
+		elseif (sqlite_num_fields($rez) == 0) {
+			$rez = true;
+		}
 
 		return $rez;
 	}
diff --git a/drivers/adodb-sqlite3.inc.php b/drivers/adodb-sqlite3.inc.php
index 64575d7f..99271038 100644
--- a/drivers/adodb-sqlite3.inc.php
+++ b/drivers/adodb-sqlite3.inc.php
@@ -193,8 +193,13 @@ class ADODB_sqlite3 extends ADOConnection {
 	function _query($sql,$inputarr=false)
 	{
 		$rez = $this->_connectionID->query($sql);
-		if (!$rez) {
-			$this->_connectionID->lastErrorCode();
+		if ($rez === false) {
+			$this->_errorNo = $this->_connectionID->lastErrorCode();
+		}
+		// If no data was returned, we don't need to create a real recordset
+		elseif ($rez->numColumns() == 0) {
+			$rez->finalize();
+			$rez = true;
 		}
 
 		return $rez;