summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-11-29Columns in SQLite metaindexes not reported correctly see #567Mark Newnham1-6/+3
The columns list in the metaindexes funtion in the SQLite driver was returned as a CSV list, not an array
2019-11-28adodb_strip_order_by() strips incorrectly if there are multiple order by ↵Mark Newnham2-2/+8
statements #549 If the SQL statement passed to adodb_strip_order contains multiple order by statements, the incorrect one is stripped. This change ensures that only the last one is stripped Co-Authored-By: mustafa-soner-acar <mustafa-soner-acar@users.noreply.github.com>
2019-11-24Merge branch 'PDO-Firebird-Driver'Damien Regad2-10/+521
2019-11-24Add PHPDoc blocks for classesDamien Regad1-0/+9
2019-11-24Coding guidelines, whitespaceDamien Regad1-86/+106
2019-11-24Replace `$false` by `false`Damien Regad1-5/+4
2019-11-24PR review fixesDamien Regad1-5/+1
2019-11-24Add support for pdo-firebirdMark Newnham2-0/+425
This first release of the pdo_firebird driver is known to have the following limitations: - Only supports dialect3 - Only tested with PHP7 - Only tested with Firebird 3 - function getRowAssoc() fails because PDO::firebird does not support getColumnMeta() - function moveFirst() currently fails for unknown reasons Fixes #378
2019-11-24Add meta extension points to PDO driverMark Newnham1-0/+58
Add support for the following Meta functions within the PDO driver: - metaIndexes() - metaPrimaryKeys() - metaForeignKeys() - metaProcedures() Fixes #475
2019-11-24Call driver's _affectedrows() function if it existsMark Newnham1-0/+3
2019-11-24Use camelCase for (some) function namesMark Newnham1-10/+11
- beginTrans - commitTrans - rollbackTrans - createSequence
2019-11-24WhitespaceDamien Regad1-9/+9
2019-11-24mssqlnative: delegate _numOfFields init to _fetchFields()Damien Regad2-5/+2
The recent release of the PHP mssql native driver (5.6) has introduced an issue that causes ADODB/PHP to crash on any query that returns no fields/data. Until a fix is available, we remove the sqlsrv_field_metadata() call in _initrs() method, since the _numOfFields property is anyway initialized as part of _fetchFields() execution. Fixes #492
2019-11-24Merge branch 'hotfix/5.20' (5.20.15)Damien Regad2-71/+68
Conflicts: docs/changelog.md
2019-11-24Reset version to avoid merge conflictsDamien Regad130-131/+131
2019-11-24Bump version to 5.20.15v5.20.15Damien Regad131-132/+132
2019-11-24Fix broken markdown in 4.x changelogDamien Regad1-69/+64
2019-11-24Fix broken documentation reference in changelogDamien Regad1-1/+1
In 5.06, a link was referencing the old html documentation. Changed to adodb.org instead.
2019-11-24Update changelogDamien Regad1-0/+2
2019-11-24Merge branch 'hotfix/5.20'Damien Regad2-156/+208
# Conflicts: # adodb-lib.inc.php
2019-11-24Reduce code duplication in _adodb_getmenu functionsDamien Regad1-81/+80
Create 2 new internal functions - _adodb_getmenu_select() to print the SELECT tag, and - _adodb_getmenu_option() to print the OPTION tags and call them from _adodb_getmenu() / _adodb_getmenu_gp().
2019-11-24New getMenuGrouped() method, deprecate getMenu3()Damien Regad1-12/+38
The new function is the same as getMenu3(), except that it has an extra parameter $compareFirstCol to align it with getMenu(). The new param defaults to true, i.e. defaults are compared against the value, not the description (opposite of getMenu3()). getMenu3() is marked as deprecated and just calls the new function.
2019-11-24PHPDoc update for getMenu3()Damien Regad1-6/+22
Coding guidelines / whitespace.
2019-11-24Mark getMenu2() as deprecatedDamien Regad1-0/+2
It has been noted as such in the documentation since 01.01.2019, but the code had not been updated accordingly.
2019-11-24PHPDoc update for getMenu2()Damien Regad1-6/+18
Coding guidelines / whitespace.
2019-11-24getMenu() rename last param to $compareFirstColDamien Regad1-4/+4
2019-11-24Code cleanup for _adodb_getmenu()/_adodb_getmenu_gp()Damien Regad1-71/+69
- Whitespace - Coding guidelines - Remove unused variables - Remove empty if statements - Optimization
2019-11-24Fix getMenu() for ADODB_FETCH_BOTHDamien Regad1-15/+21
Commit 61c5a8cf0ea9df2777eed7d1bb7935593aa93545 (see #460) introduced a regression in the behavior of getMenu() when ADODB_FETCH_MODE is set to ADODB_FETCH_BOTH, causing it to use the recordset's first column for both the select options' value and description. Fixes #482
2019-11-24PHPDoc update for getMenu()Damien Regad1-16/+16
2019-11-23Whitespace / commentsDamien Regad1-9/+4
2019-11-23Avoid if statement within foreach loopDamien Regad1-24/+17
Slightly more efficient code and removes PHPStorm warning about uninitialized variable.
2019-11-23Fix indentationDamien Regad1-68/+68
2019-11-23Fix return type not matching function definitionDamien Regad1-1/+1
2019-11-23PHPDocDamien Regad2-43/+56
2019-11-22Merge branch 'hotfix/5.20'Damien Regad2-0/+7
2019-11-22pgsql: stop using obsolete pg_attrdef.adsrc columnDamien Regad2-0/+7
Historically, the 'adsrc' column was used to retrieve a human-readable representation of a column's default value. Starting with PostgreSQL 8.0 it is considered obsolete, and it was removed in 12.0 [[1]]. Its usage has been replaced by pg_get_expr(adbin, adrelid), in postgres8 driver, per documentation[[2]]. Fixes #562 [1]: https://www.postgresql.org/docs/12/release-12.html#id-1.11.6.6.4 [2]: https://www.postgresql.org/docs/12/catalog-pg-attrdef.html
2019-11-12Codespell assisted typo cleaningJean-Michel Vourgère46-99/+99
2019-11-12Comment update (#559)nirgal1-2/+3
adodb.inc.php actually uses postgres9, not postgres7
2019-08-23Merge branch 'hotfix/5.20'Damien Regad1-1/+1
2019-08-23duhDamien Regad1-1/+1
2019-08-23Merge branch 'hotfix/5.20'Damien Regad2-2/+3
# Conflicts: # docs/changelog.md
2019-08-23PHP 7.4: fix deprecated usage of join()Damien Regad2-2/+2
Passing parameters to implode() in reverse order is deprecated Fixes #547
2019-06-25Syntax error prevents correct sequence creation see #540Mark Newnham1-1/+1
The feature that duplicates auto-increment key fields does not work if the start number for the sequence is greater than 1
2019-05-08Merge branch 'hotfix/5.20'Damien Regad4-24/+30
# Conflicts: # docs/changelog.md
2019-05-08Merge branch 'i536-activerecord-case' into hotfix/5.20Damien Regad3-23/+23
2019-05-08Update changelogDamien Regad1-0/+1
2019-05-08Use ADODB_ASSOC_CASE_xxx constantsDamien Regad2-6/+6
Code cleanup: avoid use of "magic" numbers.
2019-05-08Convert if/elseif to switchDamien Regad1-8/+11
Same change that was done in adodb-active-recordx.inc.php a few years ago (see 9f81c75d4566fea795be7024c9415909f094bf15), without the regression fixed in previous commit.
2019-05-08Fix incorrect switch statementDamien Regad1-1/+1
This is a regression from 9f81c75d4566fea795be7024c9415909f094bf15. As part of a code cleanup exercise, an if statement was converted to switch, but the evaluated expression was not correctly transformed.
2019-05-08active record: Use ADODB_ASSOC_CASE constantDamien Regad2-12/+8
Until now, active Record used an $ADODB_ASSOC_CASE *variable* to control the fields' case, which is not used or referenced anywhere else in the ADOdb library. The correct, documented way of setting the fields' case in associative fetch mode is to define the ADODB_ASSOC_CASE constant before including adodb.inc.php. This commit replaces usages of $ADODB_ASSOC_CASE variable by the ADODB_ASSOC_CASE constant. Fixes #536 (follow-up on #535)