summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2025-05-01Bump version to 5.22.9v5.22.9Damien Regad2-3/+3
2025-05-01Mark pg_insert_id() as deprecatedDamien Regad1-0/+1
This function does the same thing as ADODB_postgres8::_insertID(), in a more limited way. There is no reason to keep it around. Fixes #1069
2025-05-01PHPDocDamien Regad1-2/+10
2025-05-01Merge branch 'sec-pgsql-sql-injection' into hotfix/5.22Damien Regad2-1/+7
Advisory https://github.com/ADOdb/ADOdb/security/advisories/GHSA-8x27-jwjr-8545 Fixes #1070
2025-05-01Update changelogDamien Regad1-0/+5
2025-05-01Fix SQL injection in pg_insert_id()Damien Regad1-1/+2
Properly escape the $tablename and $fieldname parameters used to build the sequence name.
2025-04-26Active record: Fix PHP 8.2 deprecation warningDamien Regad3-0/+4
Creation of dynamic property MyClass::$column is deprecated in .../adodb/adodb-active-record.inc.php on line 115 Creation of dynamic property MyClass::$column is deprecated in .../adodb/adodb-active-recordx.inc.php on line 119 Fixes #1068
2025-03-23Fulfill SQLite PRIMARY KEY AUTOINCREMENT requirementsDamien Regad14-17/+36
- Extend _CreateSuffix() with two additional parameters. - Adjust _createSuffix function name. - Add PHPDoc block - Fix spaces Fixes #1055 Signed-off-by: Damien Regad <dregad@mantisbt.org> Changes from PR: - Original commits squashed - Removed space after `&` for byref params - Updated Changelog
2025-03-22Update changelogDamien Regad1-0/+6
2025-03-22Fix SQLite error reportingraspopov1-7/+13
Without debug flag, the library returns '0' instead of error messages and correct SQLite error codes. Fixes #1061, PR #1062
2025-03-22Bump version to 5.22.9-devDamien Regad2-1/+4
2025-01-25Bump version to 5.22.8v5.22.8Damien Regad2-3/+3
2025-01-25Update ChangelogDamien Regad1-5/+23
2025-01-25mysqli: Improve setConnectionParameterlook-was-here1-8/+60
- Simplify control statements with single if expressions. - Updated phpdoc with additional details on how to set connection property values. - Removed to-do that seemed wrong since the user should use setConnectionParameter for those or set the property directly. - Allow setting of ssl cert property values, clientFlags, port, and socket using the standard setConnectionParameter functionality. Feedback updates: - Return false for special cases with type checks on sslsert, socket, clientflags, or port fail - Added invalid connection param to output. - Simplified isset checks. - Changed sslcert to ssl and simplified subkeys to ('key', 'cert', 'ca', 'capath', 'cipher'). - Removed code duplication. - is_numeric should be checking value not parameter Fixes #1044
2025-01-25mysql: SSL not working due to wrong socket/flagslook-was-here1-2/+7
- Remove inappropriate setting of socket. - Updated to use appropriate bitwise operations to check for set SSL client flags and update the default to not overwrite set user flags. - Add friendly error to let user know they need to add a SSL client flag when using certificates. Fixes #919, #1043 Signed-off-by: Damien Regad <dregad@mantisbt.org>
2025-01-25Fix PHP 8.1 deprecation warningsJ.Mourgues1-4/+4
In toexport.inc.php: - trim(): Passing null to parameter of type string is deprecated Fixes #1045 Signed-off-by: Damien Regad <dregad@mantisbt.org>
2025-01-25pgsql: fix serverInfo() version numberDamien Regad1-6/+5
In ADOdb versions < 5.21.0-beta.1, serverInfo()['version'] returned just the version number (e.g. `15.10`), which was extracted from the version string using ADOConnection::_findVers(). Commit f2b88e063d61b12a1df9090b8d0c68831ed0f447 removed the _findVers() call, so serverInfo() could potentially return additional information depending on the actual value returned by pg_version() (e.g. `15.10 (Debian 15.10-0+deb12u1)`. This could cause subsequent version comparisons to fail, e.g. in metaTables(). Fixes #1059
2024-12-15Fix PHP deprecation warningDamien Regad1-1/+1
strcasecmp(): Passing null to parameter of type string is deprecated in adodb-lib.inc.php on line 369 Fixes #1054
2024-08-28db2: fix connections using *LOCAL on IBM i seriesDamien Regad1-13/+40
Fixes: - Support blank username and password for *LOCAL connections (#1031) - Driver confuses schema name for database name (#1032) PR https://github.com/ADOdb/ADOdb/pull/1034
2024-08-28Fixing DB2 *LOCAL connectionCalvin Buckley1-9/+4
Per https://github.com/ADOdb/ADOdb/pull/1034#issuecomment-2136155259 Signed-off-by: Damien Regad <dregad@mantisbt.org> Fixed conflict resolution when applying patch.
2024-08-28move local schema outside of debug blockMark Newnham1-2/+5
2024-08-28Added SCHEMA to *LOCALMark Newnham1-8/+6
2024-08-28Added SET SCHEMA supportMark Newnham1-0/+8
2024-08-28Handle connection re-use using *LOCALMark Newnham1-13/+36
2024-08-25Add Georgian language (#1042)NorwayFun1-0/+52
(cherry picked from commit 1e0e602ed72628f7a6665f5c925e93a80bdbd710)
2024-08-25PHPDocDamien Regad1-12/+17
2024-05-26PHPDocDamien Regad1-3/+5
2024-05-26Fix undefined variable noticesDamien Regad1-5/+8
Fixes #1010
2024-05-26oci8: fix warning in qStr() with NULL on PHP 8.1Damien Regad2-7/+8
This is a follow-up commit on 1501ccd07868d626a51802d14ed41ed05a3532ad, as the original fix for #999 (see PR #1005) did not fully address the problem. Another PHP deprecated warning is thrown: strlen(): Passing null to parameter 1 ($string) of type string is deprecated. Fixes #1012 Backported from commit 8d88183538ae08b86c30af5b0f3280c2accd71c3.
2024-05-26Reset fetch mode before return from MetaColumns()Damien Regad1-5/+3
Commit 249b7fb08569ce576cd1bf26098e00701145c6ec (PR #1017) introduced a regression caused by returning from the function without resetting $ADODB_FETCH_MODE to its original value. Fixes #1016
2024-04-30Update ChangelogDamien Regad1-0/+11
2024-04-30MySQL: allow forcing emulated prepared statementsPaweł Kudzia1-0/+23
ADOdb 5.22.0 introduced use of bound variables and prepared statements, which broke compatibility with Manticore Search and ClickHouse. Adding $doNotUseBoundVariables property, allowing to revert to emulated prepared statements, used in ADODb until v5.21. Fixes #1028, PR #1029 Co-authored-by: Damien Regad <dregad@mantisbt.org> Reworded and formatted PHPDoc block, fixed coding guidelines.
2024-03-22Remove test file committed by mistakeDamien Regad1-68/+0
2024-03-22ldap: PHP 8.2 error when $LDAP_CONNECT_OPTIONS not setDamien Regad1-1/+1
Calling connect() method When the $LDAP_CONNECT_OPTIONS global variable is not set results in PHP Fatal error: Uncaught TypeError: count(): Argument 1 ($value) must be of type Countable|array, null given. Replacing count()>0 by !empty() to avoid the problem. Fixes #1009
2024-03-22Fix getAssoc() with ADODB_FETCH_DEFAULT modeDamien Regad2-3/+73
With mysqli (and possibly with other drivers where driver-specific fetchMode values are different from ADOdb's as well, but this has not been tested), getAssoc() would not return the expected key=>value pairs when fetch mode was set to ADODB_FETCH_DEFAULT. We now use ADORecordSet::$adodbFetchMode property as reference fetch mode instead of the driver-specific ADOConnection::$fetchMode (which is often not set), and check it against both ADODB_FETCH_BOTH and ADODB_FETCH_DEFAULT. Fixes #1023
2024-03-22Fix PHP deprecated warningDamien Regad2-10/+6
adodb-active-record.inc.php. / ADODB_Active_Record::Update() throws "strcmp(): Passing null to parameter 1 ($string1) of type string is deprecated" when setting a column to null. Apply the same code change to adodb-active-recordx.inc.php. Fixes #1021
2024-01-10Update ChangelogDamien Regad1-0/+7
2024-01-10Catch getAssoc() execution error in metaColumns()Jessie den Ridder1-0/+4
When getAssoc() returns false, metaColumns() throws PHP Fatal error on array_change_key_case, bool given instead of array. We now check that getAssoc() completed successfully before continuing, and abort if not. Fixes #1016 Signed-off-by: Damien Regad <dregad@mantisbt.org>
2024-01-10 _adodb_backtrace() output with outp() instead of printDamien Regad1-1/+1
Fixes #1018
2024-01-10Bump version to 5.22.8-devDamien Regad2-1/+5
2023-11-04Bump version to 5.22.7v5.22.7Damien Regad2-3/+3
2023-11-04oci8: Fix Automatic conversion of false to arrayDamien Regad2-1/+3
On PHP 8.1, when the _query() method is called, the oci8 driver throws Automatic conversion of false to array is deprecated. Fixes #998
2023-11-01Update ChangelogDamien Regad1-0/+6
2023-11-01Fix mysqli bulkBind reset after one callSidney Beck Nys1-0/+2
Stored the current bulkBind value in a variable so $this->bulkBind can be reset after being set to false. Fixes #1000 (PR #1300)
2023-11-01Prevent str_replace NULL test error in PHP 8.1 (#1005)Mark Newnham1-0/+3
2023-07-25Remove unnecessary is_array() checkDamien Regad1-23/+22
2023-07-25oci8: deprecation warning in selecLimit() on PHP 8.1wesyah2341-4/+5
'Automatic conversion of false to array is deprecated' warning is triggered when $inputarr parameter is not provided (defaulted to false). Fixes #992
2023-06-12Update ChangelogDamien Regad1-0/+2
2023-06-12Respect @ operator in all error handlers on PHP 8Nathan Gibbs2-2/+17
error_reporting()'s return value for suppressed errors changed from 0 to 4437 in PHP 8.0.0 [1]. Follow up on commit 943ac8a7de20117d85860a9b67f9eb65c5dfe4d7. Fixes #981 (PR #984)
2023-06-12Update ADODB_db2::_query() declaration to match parentDamien Regad2-1/+7
Regression from ae2438b731d24bf0bb159a738599b9266120e96e. Fixes #987