| Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
This function does the same thing as ADODB_postgres8::_insertID(), in
a more limited way. There is no reason to keep it around.
Fixes #1069
|
|
|
|
Advisory
https://github.com/ADOdb/ADOdb/security/advisories/GHSA-8x27-jwjr-8545
Fixes #1070
|
|
|
|
Properly escape the $tablename and $fieldname parameters used to build
the sequence name.
|
|
Creation of dynamic property MyClass::$column is deprecated in
.../adodb/adodb-active-record.inc.php on line 115
Creation of dynamic property MyClass::$column is deprecated in
.../adodb/adodb-active-recordx.inc.php on line 119
Fixes #1068
|
|
- Extend _CreateSuffix() with two additional parameters.
- Adjust _createSuffix function name.
- Add PHPDoc block
- Fix spaces
Fixes #1055
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Changes from PR:
- Original commits squashed
- Removed space after `&` for byref params
- Updated Changelog
|
|
|
|
Without debug flag, the library returns '0' instead of error messages
and correct SQLite error codes.
Fixes #1061, PR #1062
|
|
|
|
|
|
|
|
- Simplify control statements with single if expressions.
- Updated phpdoc with additional details on how to set connection
property values.
- Removed to-do that seemed wrong since the user should use
setConnectionParameter for those or set the property directly.
- Allow setting of ssl cert property values, clientFlags, port, and
socket using the standard setConnectionParameter functionality.
Feedback updates:
- Return false for special cases with type checks on sslsert, socket,
clientflags, or port fail
- Added invalid connection param to output.
- Simplified isset checks.
- Changed sslcert to ssl and simplified subkeys to ('key', 'cert', 'ca',
'capath', 'cipher').
- Removed code duplication.
- is_numeric should be checking value not parameter
Fixes #1044
|
|
- Remove inappropriate setting of socket.
- Updated to use appropriate bitwise operations to check for set SSL
client flags and update the default to not overwrite set user flags.
- Add friendly error to let user know they need to add a SSL client flag
when using certificates.
Fixes #919, #1043
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
In toexport.inc.php:
- trim(): Passing null to parameter of type string is deprecated
Fixes #1045
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
In ADOdb versions < 5.21.0-beta.1, serverInfo()['version'] returned just
the version number (e.g. `15.10`), which was extracted from the version
string using ADOConnection::_findVers().
Commit f2b88e063d61b12a1df9090b8d0c68831ed0f447 removed the _findVers()
call, so serverInfo() could potentially return additional information
depending on the actual value returned by pg_version() (e.g.
`15.10 (Debian 15.10-0+deb12u1)`.
This could cause subsequent version comparisons to fail, e.g. in
metaTables().
Fixes #1059
|
|
strcasecmp(): Passing null to parameter of type string is deprecated
in adodb-lib.inc.php on line 369
Fixes #1054
|
|
Fixes:
- Support blank username and password for *LOCAL connections (#1031)
- Driver confuses schema name for database name (#1032)
PR https://github.com/ADOdb/ADOdb/pull/1034
|
|
Per https://github.com/ADOdb/ADOdb/pull/1034#issuecomment-2136155259
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Fixed conflict resolution when applying patch.
|
|
|
|
|
|
|
|
|
|
(cherry picked from commit 1e0e602ed72628f7a6665f5c925e93a80bdbd710)
|
|
|
|
|
|
Fixes #1010
|
|
This is a follow-up commit on 1501ccd07868d626a51802d14ed41ed05a3532ad,
as the original fix for #999 (see PR #1005) did not fully address the
problem. Another PHP deprecated warning is thrown:
strlen(): Passing null to parameter 1 ($string) of type string is
deprecated.
Fixes #1012
Backported from commit 8d88183538ae08b86c30af5b0f3280c2accd71c3.
|
|
Commit 249b7fb08569ce576cd1bf26098e00701145c6ec (PR #1017) introduced a
regression caused by returning from the function without resetting
$ADODB_FETCH_MODE to its original value.
Fixes #1016
|
|
|
|
ADOdb 5.22.0 introduced use of bound variables and prepared statements,
which broke compatibility with Manticore Search and ClickHouse.
Adding $doNotUseBoundVariables property, allowing to revert to emulated
prepared statements, used in ADODb until v5.21.
Fixes #1028, PR #1029
Co-authored-by: Damien Regad <dregad@mantisbt.org>
Reworded and formatted PHPDoc block, fixed coding guidelines.
|
|
|
|
Calling connect() method When the $LDAP_CONNECT_OPTIONS global variable
is not set results in PHP Fatal error: Uncaught TypeError: count():
Argument 1 ($value) must be of type Countable|array, null given.
Replacing count()>0 by !empty() to avoid the problem.
Fixes #1009
|
|
With mysqli (and possibly with other drivers where driver-specific
fetchMode values are different from ADOdb's as well, but this has not
been tested), getAssoc() would not return the expected key=>value pairs
when fetch mode was set to ADODB_FETCH_DEFAULT.
We now use ADORecordSet::$adodbFetchMode property as reference fetch
mode instead of the driver-specific ADOConnection::$fetchMode (which is
often not set), and check it against both ADODB_FETCH_BOTH and
ADODB_FETCH_DEFAULT.
Fixes #1023
|
|
adodb-active-record.inc.php. / ADODB_Active_Record::Update() throws
"strcmp(): Passing null to parameter 1 ($string1) of type string is
deprecated" when setting a column to null.
Apply the same code change to adodb-active-recordx.inc.php.
Fixes #1021
|
|
|
|
When getAssoc() returns false, metaColumns() throws PHP Fatal error on
array_change_key_case, bool given instead of array.
We now check that getAssoc() completed successfully before continuing,
and abort if not.
Fixes #1016
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Fixes #1018
|
|
|
|
|
|
On PHP 8.1, when the _query() method is called, the oci8 driver throws
Automatic conversion of false to array is deprecated.
Fixes #998
|
|
|
|
Stored the current bulkBind value in a variable so $this->bulkBind can
be reset after being set to false.
Fixes #1000 (PR #1300)
|
|
|
|
|
|
'Automatic conversion of false to array is deprecated' warning is
triggered when $inputarr parameter is not provided (defaulted to false).
Fixes #992
|
|
|
|
error_reporting()'s return value for suppressed errors changed from 0 to
4437 in PHP 8.0.0 [1].
Follow up on commit 943ac8a7de20117d85860a9b67f9eb65c5dfe4d7.
Fixes #981 (PR #984)
|
|
Regression from ae2438b731d24bf0bb159a738599b9266120e96e.
Fixes #987
|