| Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
- Document false instead of bool if the function cannot return true
Many other functions document <foo>|false
- Correct the @return description for GetCol()
|
|
|
|
|
|
|
|
|
|
With mysqli (and possibly with other drivers where driver-specific
fetchMode values are different from ADOdb's as well, but this has not
been tested), getAssoc() would not return the expected key=>value pairs
when fetch mode was set to ADODB_FETCH_DEFAULT.
We now use ADORecordSet::$adodbFetchMode property as reference fetch
mode instead of the driver-specific ADOConnection::$fetchMode (which is
often not set), and check it against both ADODB_FETCH_BOTH and
ADODB_FETCH_DEFAULT.
Fixes #1023
|
|
|
|
|
|
Internal, low-level connection methods are driver-specific, but they
nevertheless need to be declared in the parent ADOConnection class, in
order to define a common signature and avoid potentially polymorphic
calls.
_nconnect() exists, but the _connect() and _pconnect() methods were
missing.
The _connect() method is defined as abstract to force its implementation
in the child Driver classes.
Since they are for internal use, all 3 methods are declared as protected
(in ADOConnection only, not in child classes - for now). Note that this
does not actually break backwards compatibility, as PHP allows child
classes to relax the visibility (i.e. redeclare the methods as public).
At some point we'll need to align this across the library.
Fixes #1013
|
|
|
|
This is a follow-up on commit bffa42e206d758af3095b8a0bdbf3c3ad8fb5e51.
Following removal of adodb-time library, some function calls were not
cleaned up in the code base. This fixes that.
Includes a standalone test script to validate the functionality.
Fixes #970 (PR #1002)
|
|
|
|
|
|
|
|
Code is simplified using the new ADOFieldObj constructor.
The ADORecordSet properties $_obj and $_names are no longer needed and
have been removed.
Issue #982
|
|
This allows hanlding of dynamic properties for PHP 8.2 compatibility,
without relying on the AllowDynamicProperties attribute.
The constructor accepts an array of (fieldname => value) pairs for easy
initialization.
Fixes #982
|
|
|
|
Avoid deprecation warning on PHP 8.2.
Fixes #975, as temporary workaround for #982
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
This reduces code duplication as the logic to initialize $fetchMode from
$ADODB_FETCH_MODE global was repeated in most drivers.
$adodbFetchMode is systematically initialized as well now; previously it
was only set in those drivers having specific fetch modes.
Fixes #958
|
|
It does not make much sense anymore in the age of 64-bit computing,
where timestamps will not overflow for 292 billion years...
Fixes #970
|
|
|
|
- Update child classes to be consistent with this declaration.
- Remove unnecessary, non-PHPDoc comments
- Consistent parameter names
Fixes #966
|
|
Remove redundant PHPDoc block in child classes ADODB_mysqli, ADODB_oci8.
Fixes #964
|
|
Merge commit 917c54ec9d0df1bb34fe80a71336b446f09d74ae did not resolve
conflicted adodb.inc.php correctly: changes in the hotfix/5.22 branch
were simply ignored instead of being selectively applied.
As a result, the fix for #954 and some PHPDoc improvements were not
applied.
Fixes #960
|
|
Fixes #954
|
|
|
|
|
|
Only append newline (`<br>` or `\n` depending on HTML/CLI output) when
necessary, instead of always adding a `<br>` and stripping tags
afterwards for CLI.
|
|
|
|
|
|
|
|
|
|
safe_mode was deprecated in PHP 5.3 and removed in 5.4. This removes
remaining references to it in the code.
Fixes #934
|
|
- ADOConnection: add $_metars, $locale, $metaColumnsSQL, $identitySQL,
$_genSeqSQL, $_dropSeqSQL and $_genIDSQL; add PHPDoc to
$metaDatabasesSQL $metaTablesSQL
- Exceptions: add $msg property
- DB2: reference parent connection object and fix $_queryID case
- Informix: don't cache version info in SetVersion
- odbtp: define $odbc_name, $_canSelectDb, $_lastAffectedRows properties
NOTE: this is somewhat academical as the driver is obsolete
- oci8: define $_refcursor property
- sybase: use existing $hasTransactions property instead of $_hastrans
- text: rename unused ADOConnection::$_evalAll property to $evalAll
- perf: define $settings property
- xml: add properties dbTable::$currentPlatform, dbTable::$data,
dbData::$current_field, adoSchema:$obj
This is adapted from changes proposed in #926
|
|
Adapt the few drivers that were previously using this property.
Fixes dynamic properties deprecation in PHP 8.2
Based on original submission in PR #926
|
|
Fixes #906
|
|
Fixes #906
|
|
# Conflicts:
# adodb.inc.php
|
|
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Fixes PHP 8.2 Deprecated warning: Creation of dynamic property.
Fixes #908
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Fixes PHP 8.2 Deprecated warning: Creation of dynamic property.
Fixes #909
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Cherry picked from commits feadc3df1fdb199bbef50eb404f81b7d78f94c79 and
5e41924806e5f310d30e203100f0c97cd5e93893.
# Conflicts:
# adodb.inc.php
Creation of dynamic property
- ADORecordset_sqlite3::$adodbFetchMode in adodb-sqlite3.inc.php (#911)
- ADOFieldObject::$scale in adodb-sqlite3.inc.php (#912)
Partially-supported callable
- in adodb-pdo-inc.php (#928)
|
|
ADOConnection::$databaseName was marked as obsolete in ADOdb 4.66.
Since the assignment that was kept for backwards-compatibility in the
ADOConnection::selectDB() method is causing deprecation warnings with
PHP 8.2, now is the time to get rid of it.
The 2018 rewrite of DB2 driver introduced a private $databaseName
property; this has been removed in favor of ADOConnection::$database.
Fixes #932, #904
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
|
|
Creation of dynamic property
- ADORecordset_sqlite3::$adodbFetchMode in adodb-sqlite3.inc.php (#911)
- ADOFieldObject::$scale in adodb-sqlite3.inc.php (#912)
Partially-supported callable
- in adodb-pdo-inc.php (#928)
---------
This is a re-do of fa572e96d20ac233e9dfc2d8f770234475381107 (PR #921)
with an improved commit message.
Co-authored-by: raortegar <raquel.ortega@moodle.com>
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Nothing wrong with the code changes, but the commit message is bit of a
mess, so I'll re-apply it after rewording.
|
|
deprecated in driversadodb sqlite3incphp on line 194 (#931)
* Fixed Partially-supported callable are deprecated in PHP 8.2
* Fix deprecated undefined property #912 #911 #920 #923
---------
Co-authored-by: raortegar <raquel.ortega@moodle.com>
|
|
|