| Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Following discussion in #718, using regex to identify and remove
sub-queries in _adodb_getcount() is flawed and can't be fixed. This led
to implementing a hack using _ADODB_COUNT "keyword" to (see #88
41839f5c18abe262ee088f1d4bd92453616d2a4a).
This replaces the regex parsing by a simple loop on the query string,
removing everything between the SELECT and the FROM clause, ignoring
whatever is between parentheses (i.e. subqueries).
The _ADODB_COUNT logic is therefore obsolete
Fixes #715
|
|
In ADOdb 5.21.0, for performance reasons [1] the _query() method no
longer retrieves the last inserted Id.
This introduced a regression, as it was only possible to retrieve the
Insert Id for "normal" queries, but not parameterized ones as
Insert_ID() always returned null in this case.
To maintain the driver's performance, we now allow the client to
decide whether insert queries should execute the extra SCOPE_IDENTITY()
call, by providing a new enableLastInsertID() method.
Fixes #692
[1]: https://github.com/ADOdb/ADOdb/issues/185#issuecomment-169057606
|
|
Update child classes so method signature matches the parent's.
|
|
|
|
Add error handling for $parameter type: since mysqli_options() requires
an integer, the function now fails and returns false (or throws an
exception if enabled) when given a non-numeric value.
Fixes #693
|
|
|
|
The property was defined in the middle of methods, moved it up with
other class properties where it belongs.
Improved PHPDoc now includes data structure description and explanation.
|
|
|
|
|
|
Fix whitespace
|
|
This was a mistake, as discussed in [[1]].
Fixes #694
[1]: https://github.com/ADOdb/ADOdb/issues/693#issuecomment-795251586
|
|
|
|
|
|
|
|
Allowing param(false) to reset the query parameter count (see #380,
commit 46fa66c10dc50547167d0f8bbbcb6484edf30d1c) introduced a regression
when a falsy value was used, like `param(0)` in adodb-session2.php.
ADODB_postgres64::param() now differenciates betwen use of:
- falsy value -> reset count and return the first placeholder ($1)
- boolean `false` -> reset count, do not return placeholder (next call
will return $1).
Updated PHPDoc for parent ADOConnection::param() to reflect this.
Fixes #682, #380
|
|
|
|
The $magic_quote parameter for public methods was kept for backwards
compatibility purposes, but is no longer used.
Fixes #674
|
|
# Conflicts:
# adodb.inc.php
|
|
Follow-up on #657, applies the same logic to remaining usages.
This code will be removed in ADOdb 5.21.0.
Fixes #619
|
|
# Conflicts:
# adodb-xmlschema03.inc.php
# adodb.inc.php
# drivers/adodb-pdo.inc.php
|
|
|
|
$raiseErrorFn, $fnExecute and $fnCacheExecute are expected to contain
callables, but as they are declared as false initially.
This causes PHPStorm to incorrectly flag usage in the code as errors:
Function name must be callable - a string, Closure or class
implementing __invoke, currently bool
|
|
Fixes #646
|
|
|
|
Change web site references from http://adodb.org to https.
|
|
Note on merge conflict in adodb.inc.php:
At line 5133, parse_url() is called with `@` operator in the hotfix/5.20
branch (commit 2026e66e86f35995eee32557c2f83f1d539ca9c7) whereas the
same change in the master branch (commit c1a6794ece2b02c2a5d238159ae85da3cbd6d)
is without it. Code was kept as it is in master.
# Conflicts:
# adodb-lib.inc.php
# adodb.inc.php
# drivers/adodb-mssqlnative.inc.php
# drivers/adodb-mysqli.inc.php
# drivers/adodb-pdo.inc.php
|
|
|
|
Update of $ADODB_vers was missed in the previous bump commit.
|
|
|
|
The # symbol disupts the parse_url function so the password is temorarily substituted during the url decoding phase
|
|
The # symbol disupts the parse_url function so the password is temorarily substituted during the url decoding phase
|
|
|
|
|
|
|
|
# Conflicts:
# docs/changelog.md
|
|
When using transactions (startTrans/completeTrans), the ADOdb Exception
thrower function ($raiseErrorFn property) is replaced by a specific
handler (ADODB_TransMonitor method), which itself calls the original
handler (adodb_throw) by default.
ADODB_TransMonitor incorrectly overwrites the $fn parameter (which
drives the behavior of the ADODB_Exception class constructor) with the
name of the original handler, causing ADOdb_Exception::__construct()
to throw an "Array to string conversion" PHP notice when the query
triggering the exception has parameters.
Using a dedicated variable to store and call the original handler fixes
the problem.
Fixes #601
|
|
Always clone, but left in mysqli check for PHP7
|
|
|
|
If ADODB_FETCH_MODE is ADODB_FETCH_BOTH, and 2 columns were returned,
the first column was returned as both the key and the value.
Fixes #600
|
|
|
|
|
|
Fixes #445
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Rebased, conflicts resolved, fixed whitespace (indent with spaces).
|
|
|
|
This is @laurent-n's original submission from PR #489 with some
whitespace adjustments, rebased to latest master.
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Microsoft wraps column names in square brackets in T-SQL statements,
which is not really obligatory but becomes necessary when reserved
keywords are used as columns names (e.g. 'BEGIN' or 'CURRENT').
Fixes #246
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Original commits from PR squashed and message reworded.
|
|
|
|
# Conflicts:
# adodb-lib.inc.php
|
|
The new function is the same as getMenu3(), except that it has an extra
parameter $compareFirstCol to align it with getMenu(). The new param
defaults to true, i.e. defaults are compared against the value, not the
description (opposite of getMenu3()).
getMenu3() is marked as deprecated and just calls the new function.
|
|
Coding guidelines / whitespace.
|