| Age | Commit message (Collapse) | Author | Files | Lines |
|
If the specified where clause returns no rows, then we return false
early, there is no point building and executing an UPDATE statement
that will do nothing.
Fixes #1148
|
|
|
|
AutoExecute fetches a row from the table prior to performing an insert
or update. When $forceUpdate is false, only modified columns should be
updated. However, the WHERE clause was not being used when fetching the
row, so the comparison was always made against an arbitrary row, causing
differences to be detected or missed by chance.
This change makes use of the $where parameter when fetching the row from
the table, making the comparison work as intended.
Fixes #1146
|
|
Non-canonical cast (integer) is deprecated, use the (int) cast instead
Global search and replace throughout the code base.
Fixes #1143
|
|
|
|
|
|
|
|
|
|
With mysqli (and possibly with other drivers where driver-specific
fetchMode values are different from ADOdb's as well, but this has not
been tested), getAssoc() would not return the expected key=>value pairs
when fetch mode was set to ADODB_FETCH_DEFAULT.
We now use ADORecordSet::$adodbFetchMode property as reference fetch
mode instead of the driver-specific ADOConnection::$fetchMode (which is
often not set), and check it against both ADODB_FETCH_BOTH and
ADODB_FETCH_DEFAULT.
Fixes #1023
|
|
|
|
|
|
|
|
|
|
Avoid deprecation warning on PHP 8.2.
Fixes #975, as temporary workaround for #982
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
- Update child classes to be consistent with this declaration.
- Remove unnecessary, non-PHPDoc comments
- Consistent parameter names
Fixes #966
|
|
Remove redundant PHPDoc block in child classes ADODB_mysqli, ADODB_oci8.
Fixes #964
|
|
Fixes #954
|
|
|
|
|
|
|
|
|
|
safe_mode was deprecated in PHP 5.3 and removed in 5.4. This removes
remaining references to it in the code.
Fixes #934
|
|
- ADOConnection: add $_metars, $locale, $metaColumnsSQL, $identitySQL,
$_genSeqSQL, $_dropSeqSQL and $_genIDSQL; add PHPDoc to
$metaDatabasesSQL $metaTablesSQL
- Exceptions: add $msg property
- DB2: reference parent connection object and fix $_queryID case
- Informix: don't cache version info in SetVersion
- odbtp: define $odbc_name, $_canSelectDb, $_lastAffectedRows properties
NOTE: this is somewhat academical as the driver is obsolete
- oci8: define $_refcursor property
- sybase: use existing $hasTransactions property instead of $_hastrans
- text: rename unused ADOConnection::$_evalAll property to $evalAll
- perf: define $settings property
- xml: add properties dbTable::$currentPlatform, dbTable::$data,
dbData::$current_field, adoSchema:$obj
This is adapted from changes proposed in #926
|
|
Adapt the few drivers that were previously using this property.
Fixes dynamic properties deprecation in PHP 8.2
Based on original submission in PR #926
|
|
Fixes #906
|
|
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Fixes PHP 8.2 Deprecated warning: Creation of dynamic property.
Fixes #908
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Fixes PHP 8.2 Deprecated warning: Creation of dynamic property.
Fixes #909
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Cherry picked from commits feadc3df1fdb199bbef50eb404f81b7d78f94c79 and
5e41924806e5f310d30e203100f0c97cd5e93893.
# Conflicts:
# adodb.inc.php
Creation of dynamic property
- ADORecordset_sqlite3::$adodbFetchMode in adodb-sqlite3.inc.php (#911)
- ADOFieldObject::$scale in adodb-sqlite3.inc.php (#912)
Partially-supported callable
- in adodb-pdo-inc.php (#928)
|
|
ADOConnection::$databaseName was marked as obsolete in ADOdb 4.66.
Since the assignment that was kept for backwards-compatibility in the
ADOConnection::selectDB() method is causing deprecation warnings with
PHP 8.2, now is the time to get rid of it.
The 2018 rewrite of DB2 driver introduced a private $databaseName
property; this has been removed in favor of ADOConnection::$database.
Fixes #932, #904
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
$where was wrongly typed as bool. Changed it to string and updated
the default value from false to ''.
Fixes #915
|
|
|
|
Ensures that the recordset is returned in the default provided by the
PHP driver as per the documentation.
Fixes #886
|
|
|
|
Partial revert of 721c31492ac77aa1bd9bdd01193cd6071087b49f.
This was an early attempt to fix #848; the actual fix was implemented in
the PostgreSQL driver, but the change to ADORecordSet::__destruct() was
not reverted.
Fixes #867
|
|
|
|
|
|
See https://github.com/ADOdb/ADOdb/pull/856#discussion_r953591183
|
|
Replace hardcoded '-1' value when creating dummy RecordSets.
Issue #848
|
|
|
|
|
|
|
|
|
|
|
|
|
|
These legacy drivers are all based on the old mysql extension, which was
deprecated in PHP 5.5 and removed in PHP 7.0.
Fixes #804
|
|
|
|
This allows Oracle users to avoid reaching the maximum open cursors
limit by releasing the statement resource allocated by oci_parse(), and
prevent occurrence of an ORA-01000 error.
The resource is cleared (set to null) after freeing statement, to avoid
keeping a resource of type Unknown in the statement.
Fixes #770
|
|
It is declared in ADOConnection since e3fa991cab89ceb9724bf8c19676a450ee62a1f8.
Convert ADOConnection::$dsnType comment to PHPDoc.
Issue #789
|
|
|