| Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
Allowing param(false) to reset the query parameter count (see #380,
commit 46fa66c10dc50547167d0f8bbbcb6484edf30d1c) introduced a regression
when a falsy value was used, like `param(0)` in adodb-session2.php.
ADODB_postgres64::param() now differenciates betwen use of:
- falsy value -> reset count and return the first placeholder ($1)
- boolean `false` -> reset count, do not return placeholder (next call
will return $1).
Updated PHPDoc for parent ADOConnection::param() to reflect this.
Fixes #682, #380
|
|
|
|
The $magic_quote parameter for public methods was kept for backwards
compatibility purposes, but is no longer used.
Fixes #674
|
|
# Conflicts:
# adodb.inc.php
|
|
Follow-up on #657, applies the same logic to remaining usages.
This code will be removed in ADOdb 5.21.0.
Fixes #619
|
|
# Conflicts:
# adodb-xmlschema03.inc.php
# adodb.inc.php
# drivers/adodb-pdo.inc.php
|
|
|
|
$raiseErrorFn, $fnExecute and $fnCacheExecute are expected to contain
callables, but as they are declared as false initially.
This causes PHPStorm to incorrectly flag usage in the code as errors:
Function name must be callable - a string, Closure or class
implementing __invoke, currently bool
|
|
Fixes #646
|
|
|
|
Change web site references from http://adodb.org to https.
|
|
Note on merge conflict in adodb.inc.php:
At line 5133, parse_url() is called with `@` operator in the hotfix/5.20
branch (commit 2026e66e86f35995eee32557c2f83f1d539ca9c7) whereas the
same change in the master branch (commit c1a6794ece2b02c2a5d238159ae85da3cbd6d)
is without it. Code was kept as it is in master.
# Conflicts:
# adodb-lib.inc.php
# adodb.inc.php
# drivers/adodb-mssqlnative.inc.php
# drivers/adodb-mysqli.inc.php
# drivers/adodb-pdo.inc.php
|
|
|
|
Update of $ADODB_vers was missed in the previous bump commit.
|
|
|
|
The # symbol disupts the parse_url function so the password is temorarily substituted during the url decoding phase
|
|
The # symbol disupts the parse_url function so the password is temorarily substituted during the url decoding phase
|
|
|
|
|
|
|
|
# Conflicts:
# docs/changelog.md
|
|
When using transactions (startTrans/completeTrans), the ADOdb Exception
thrower function ($raiseErrorFn property) is replaced by a specific
handler (ADODB_TransMonitor method), which itself calls the original
handler (adodb_throw) by default.
ADODB_TransMonitor incorrectly overwrites the $fn parameter (which
drives the behavior of the ADODB_Exception class constructor) with the
name of the original handler, causing ADOdb_Exception::__construct()
to throw an "Array to string conversion" PHP notice when the query
triggering the exception has parameters.
Using a dedicated variable to store and call the original handler fixes
the problem.
Fixes #601
|
|
Always clone, but left in mysqli check for PHP7
|
|
|
|
If ADODB_FETCH_MODE is ADODB_FETCH_BOTH, and 2 columns were returned,
the first column was returned as both the key and the value.
Fixes #600
|
|
|
|
|
|
Fixes #445
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Rebased, conflicts resolved, fixed whitespace (indent with spaces).
|
|
|
|
This is @laurent-n's original submission from PR #489 with some
whitespace adjustments, rebased to latest master.
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Microsoft wraps column names in square brackets in T-SQL statements,
which is not really obligatory but becomes necessary when reserved
keywords are used as columns names (e.g. 'BEGIN' or 'CURRENT').
Fixes #246
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Original commits from PR squashed and message reworded.
|
|
|
|
# Conflicts:
# adodb-lib.inc.php
|
|
The new function is the same as getMenu3(), except that it has an extra
parameter $compareFirstCol to align it with getMenu(). The new param
defaults to true, i.e. defaults are compared against the value, not the
description (opposite of getMenu3()).
getMenu3() is marked as deprecated and just calls the new function.
|
|
Coding guidelines / whitespace.
|
|
It has been noted as such in the documentation since 01.01.2019, but
the code had not been updated accordingly.
|
|
Coding guidelines / whitespace.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
srand() should not be called manually, unless one has a better way to
initialise the already-initialised random seed.
The way the current srand() call is made is buggy, and will lead to
duplicate random seeds if called often enough. Because the current call
will lose the timestamp part, and will only use the first 6 chars from
the current microsecond, but the system might not have a high-enough
timer resolution, so the actual pool of random seeds gets even smaller.
Fixes #532
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
When initializing a new connection with postgres or pgsql driver, ADOdb
currently defaults to using the postgres8 driver.
Postgres 8.4 lifecycle ended in 2014, and currently only versions >= 9.4
are supported, so it makes sense to change our default to connect using
the postgres9 driver instead of postgres8, even though they currently
only differ by driver name.
Fixes #474
|
|
|
|
# Conflicts:
# adodb-time.inc.php
# docs/changelog.md
# drivers/adodb-mssql.inc.php
# drivers/adodb-mssqlnative.inc.php
# drivers/adodb-oci8po.inc.php
|
|
|