| Age | Commit message (Collapse) | Author | Files | Lines |
|
Commit 52a1d8f473d90ec7f46d27a9b0439478e74659a9 introduced a regression.
The fix did not properly consider that the purpose of the isset tests
was to determine whether the recordset's fields was a numerically
0-based indexed array.
As a consequence, when calling GetAssoc() in ADODB_FETCH_ASSOC mode with
data like array('adodb', '0'), $numIndex was incorrectly set to True,
leading to an 'Undefined offset' PHP notice and wrong return value
array(0=>null) instead of array('adodb'=>'0').
Fixes #101
|
|
Update comments in the code as well as the documentation to describe
ADODB_FETCH_* and ADODB_ASSOC_CASE_ constants.
Added description of each case and usage hints.
|
|
They were previously defined in adodb-pear.inc.php, which doesn't make
much sense since they are only referenced within adodb.inc.php.
Fixes #49
|
|
No point in cluttering global workspace with a variable that is not used
anywhere after initial setup.
|
|
Fixes #57
|
|
Adds the mssql datatype datetime2 to the metatype mapping. Prevents
date time errors caused by the field being treated as a long.
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
- ADOConnection::Connect
- ADOConnection::PConnect
Fixes #63
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
There are cases where ADODB is not be able to figure out the proper
count(*) queries for PageExecute() on its own.
To work around this problem, ADOdb now handles a new keyword
"_ADODB_COUNT" that can be wrapped around the parts of the SQL query
that should be replaced with "COUNT(*)"; the code will remove everything
between and including the _ADODB_COUNT keywords and replace it with
COUNT(*). The _ADODB_COUNT tags are of course removed when COUNT(*) is
not needed.
Example usage:
SELECT
_ADODB_COUNT
col1,
col2,
col3,
( select col4 from table2 where col1=col2 )
col4,
_ADODB_COUNT
FROM table1
LEFT JOIN ( select col5 from table3 where col3=col4 ) AS tmp;
Original 2012 bug report: http://phplens.com/lens/lensforum/msgs.php?id=19058
The fix has been in use since that time in hundreds of thousands of
production installations.
Fixes #88
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Mike's original commit was split into distinct elements.
|
|
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
|
|
|
|
|
|
|
|
Added methods to ADORecordSet_empty to improve compatability with other
ADORecordSet_* types.
resolves #43, PR #45
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Fixes #24
|
|
Fixes #32
|
|
There was a small mistake in the version matching regex introduced in
commit 30c21280a48680c079f825af6583793928d65cf5, causing the function to
trigger a system notice and only return 'V' instead of the actual
version number.
Fixes #16
|
|
|
|
|
|
Fixes #13
|
|
|
|
|
|
|
|
|
|
|
|
When using 'pgsql' or 'postgres', ADOdb now sets the class to postgres8
instead of postgres7.
This is justified by PostgreSQL's versioning policy [1], as all 7.x
releases are end-of-life since 2010 or before. 8.4 is still supported
until July 2014.
[1] http://www.postgresql.org/support/versioning/
|
|
The _insertid() method introduced in postgres9 driver really belongs in
postgres8, since OID field was actually removed in 8.1.
This commit creates new postgres8 classes, moves the method from the '9'
driver to the new ADODB_postgres8 class, and makes the '9' classes
inherit from postgres8 instead of postgres7.
|
|
|
|
|
|
|
|
The old regex in ADOConnection::Version only included the numeric part
of the ADOdb version number. Now the suffix (dev|[1-z]) is also
returned.
The regex in updateversion.py has been updated to match.
|
|
If the second column of the first row happens to be null, ADOdb returned
a one-based array rather than the expected zero-based one.
Resolved by using array_key_exists() instead of isset().
Fixes sourceforge bug #130
|
|
When ADOConnection->Execute is called with a single non-array parameter
that evaluates to false, it ignores the parameter.
Fixed by doing a strict-type comparison. Note that single boolean "false"
parameter needs to be passed in as array(false).
Reported by Alejandro Vásquez
Fixes sourceforge patch #32
|
|
|
|
http://php.net/manual/en/language.basic-syntax.phptags.php
|
|
Bumped 'dev' version allows users who rely on source code downloaded
from the git repository rather than an official release tarball to
reliably determine that they are running a development version of the
library.
|
|
|
|
As suggested by user 'Harmony' in [1].
This fixes erroneous behavior when using ADODB_FETCH_ASSOC fetch mode
and a field's value is null, in which case it was not included in the
result set.
[1] http://phplens.com/lens/lensforum/msgs.php?id=17539
|
|
- Move all files in adodb5/ to root
- Remove adodb-for-php4/ directory
|