| Age | Commit message (Collapse) | Author | Files | Lines |
|
- Update child classes to be consistent with this declaration.
- Remove unnecessary, non-PHPDoc comments
- Consistent parameter names
Fixes #966
|
|
ADOConnection::$databaseName was marked as obsolete in ADOdb 4.66.
Since the assignment that was kept for backwards-compatibility in the
ADOConnection::selectDB() method is causing deprecation warnings with
PHP 8.2, now is the time to get rid of it.
The 2018 rewrite of DB2 driver introduced a private $databaseName
property; this has been removed in favor of ADOConnection::$database.
Fixes #932, #904
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
- public visibility
- camelCase
- change $owner default from false to ''
- add $associative param where missing
- PHPDoc updates
|
|
Try to do it right this time...
# Conflicts:
# adodb-memcache.lib.inc.php
Fixes #751
|
|
Fixes #751
|
|
The conflicts resolution applied when merging the Standardized file
headers (commit e9dcce3df24912ad869d0193f0b419f2309101fc) was seriously
messed up, actually overwriting a number of changes in the master
branch.
Rather than trying to go and fix things one by one which has a high risk
of messing things further, it's easier to redo the merge from a clean
slate, so this commit reverts the following:
- "Merge branch 'hotfix/5.21' Standardized file headers",
e9dcce3df24912ad869d0193f0b419f2309101fc
- "Merge tag 'v5.21.1'",
5f437df3104159d5d659f60e31bef8d33c34995f
- "Reset version to 5.22.0-dev"
af9234a525c3255af051a330164486d73be4c63a
- "Fix incorrect resolution of merge conflicts"
a6733f61b0165b366c8d2c70d9af82edc3881951.
- "Fix syntax error in toexport.inc.php"
20b01e83cb61b6b2460f64c7d1277c5f4cc28574.
Fixes #751
|
|
|
|
|
|
Update child classes so method signature matches the parent's.
|
|
|
|
|
|
|
|
The $magic_quote parameter for public methods was kept for backwards
compatibility purposes, but is no longer used.
Fixes #674
|
|
|
|
Change web site references from http://adodb.org to https.
|
|
|
|
Remove $_has_mssql_init property, which is no longer useful.
The ADODB_mssql class' constructor has been removed too, as it was no
longer doing anything.
|
|
|
|
|
|
MetaForeignKeys returns an associative array with the name of reference
table for key. But when there are 2 foreign keys from the same reference
table, MetaForeignKeys returns only the last foreign key.
A solution is to merge arrays when there are several foreign keys.
Fixes #486
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Original commits from PR squashed and message reworded.
|
|
|
|
# Conflicts:
# adodb-time.inc.php
# docs/changelog.md
# drivers/adodb-mssql.inc.php
# drivers/adodb-mssqlnative.inc.php
# drivers/adodb-oci8po.inc.php
|
|
|
|
|
|
|
|
When a string containing a leading quote (but not a trailing one was passed to _query(), the function assumed that it was a fully quoted string, then failed on execution
|
|
When a string containing a leading quote (but not a trailing one was passed to _query(), the function assumed that it was a fully quoted string, then failed on execution
|
|
|
|
|
|
I messed up the merge at c350c007ed585a4da4dc8c62ae7954cfe13b621f. Not
sure what I did or how, but the changes from the hotfix branch got lost.
Redoing the merge to fix the problem.
|
|
|
|
The `SelectLimit` function has a potential SQL injection vulnerability
through the use of the `nrows` and `offset` parameters which are not
forced to integers.
This is a follow-up on #311, and fixes all remaining drivers that do not
use ADOConnection::SelectLimit().
Fixes #401
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Original commits squashed, message reworded. Fixed whitespace.
|
|
create_function() is deprecated in PHP 7.2
http://php.net/manual/en/function.create-function.php
Fixes #404
|
|
|
|
Fixes #278
|
|
Fix actually using the alternative port if it was specified. The base
driver class will strip the port from hostname and put it in port
property. So now add it again if it was set.
Fixes #314
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The code for the 'l' format (day of week) is missing from the sqlDate function
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Same change as f0d060dbe0ce029d7800d97394da7fd66d23370e, but for mssql
driver (original change only fixed issue for mssqlnative).
Fix #232
|
|
|
|
This method was introduced in 7d941967aa1b81d636f5b6e1f3549b2fc95248b9.
As mentioned in [1], since the function is already defined in
ADODB_mssql, it does not make sense to have it in the recordset too.
@mnewnham confirmed via Gitter [2] that it should be removed.
[1] https://github.com/ADOdb/ADOdb/commit/7d941967aa1b81d636f5b6e1f3549b2fc95248b9#commitcomment-17064111
[2] "Got completely lost with that substr in the recordset, that should
not be their at all - If I put it into master it should be killed"
|
|
The methods had not been defined for SQL server connection drivers so they
returned the default 'NOT SET' values
|
|
ADOdb contains a portable connection::substring connection identifier, but
it could not be successfully used to create portable substring SQL code when
used with SQL Server, because that driver requires a mandatory 3rd length parameter
which differs from most other databases.
|
|
|
|
Conflicts:
docs/changelog.md
|
|
|