| Age | Commit message (Collapse) | Author | Files | Lines |
|
# Conflicts:
# adodb-time.inc.php
# drivers/adodb-db2.inc.php
|
|
Non-canonical cast (integer) is deprecated, use the (int) cast instead
Global search and replace throughout the code base.
Fixes #1143
|
|
This is a follow-up on commit bffa42e206d758af3095b8a0bdbf3c3ad8fb5e51.
Following removal of adodb-time library, some function calls were not
cleaned up in the code base. This fixes that.
Includes a standalone test script to validate the functionality.
Fixes #970 (PR #1002)
|
|
Regression introduced by 5c9e24cf98409004da2a5e5bd80eeec82c5a3997
For some drivers using native fetch mode constants, the $fetchMode
property was not set properly as the switch statement assigning its
value was driven by the constructor's $mode parameter instead of the
parent constructor's $adodbFetchMode property.
Fixes #980
|
|
This reduces code duplication as the logic to initialize $fetchMode from
$ADODB_FETCH_MODE global was repeated in most drivers.
$adodbFetchMode is systematically initialized as well now; previously it
was only set in those drivers having specific fetch modes.
Fixes #958
|
|
- Update child classes to be consistent with this declaration.
- Remove unnecessary, non-PHPDoc comments
- Consistent parameter names
Fixes #966
|
|
- ADOConnection: add $_metars, $locale, $metaColumnsSQL, $identitySQL,
$_genSeqSQL, $_dropSeqSQL and $_genIDSQL; add PHPDoc to
$metaDatabasesSQL $metaTablesSQL
- Exceptions: add $msg property
- DB2: reference parent connection object and fix $_queryID case
- Informix: don't cache version info in SetVersion
- odbtp: define $odbc_name, $_canSelectDb, $_lastAffectedRows properties
NOTE: this is somewhat academical as the driver is obsolete
- oci8: define $_refcursor property
- sybase: use existing $hasTransactions property instead of $_hastrans
- text: rename unused ADOConnection::$_evalAll property to $evalAll
- perf: define $settings property
- xml: add properties dbTable::$currentPlatform, dbTable::$data,
dbData::$current_field, adoSchema:$obj
This is adapted from changes proposed in #926
|
|
ADOConnection::$databaseName was marked as obsolete in ADOdb 4.66.
Since the assignment that was kept for backwards-compatibility in the
ADOConnection::selectDB() method is causing deprecation warnings with
PHP 8.2, now is the time to get rid of it.
The 2018 rewrite of DB2 driver introduced a private $databaseName
property; this has been removed in favor of ADOConnection::$database.
Fixes #932, #904
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Try to do it right this time...
# Conflicts:
# adodb-memcache.lib.inc.php
Fixes #751
|
|
Fixes #751
|
|
The conflicts resolution applied when merging the Standardized file
headers (commit e9dcce3df24912ad869d0193f0b419f2309101fc) was seriously
messed up, actually overwriting a number of changes in the master
branch.
Rather than trying to go and fix things one by one which has a high risk
of messing things further, it's easier to redo the merge from a clean
slate, so this commit reverts the following:
- "Merge branch 'hotfix/5.21' Standardized file headers",
e9dcce3df24912ad869d0193f0b419f2309101fc
- "Merge tag 'v5.21.1'",
5f437df3104159d5d659f60e31bef8d33c34995f
- "Reset version to 5.22.0-dev"
af9234a525c3255af051a330164486d73be4c63a
- "Fix incorrect resolution of merge conflicts"
a6733f61b0165b366c8d2c70d9af82edc3881951.
- "Fix syntax error in toexport.inc.php"
20b01e83cb61b6b2460f64c7d1277c5f4cc28574.
Fixes #751
|
|
|
|
Update child classes so method signature matches the parent's.
|
|
|
|
|
|
|
|
|
|
Change web site references from http://adodb.org to https.
|
|
|
|
# Conflicts:
# adodb-time.inc.php
# docs/changelog.md
# drivers/adodb-mssql.inc.php
# drivers/adodb-mssqlnative.inc.php
# drivers/adodb-oci8po.inc.php
|
|
|
|
|
|
|
|
|
|
Conflicts:
adodb.inc.php
docs/changelog.md
|
|
I messed up the merge at c350c007ed585a4da4dc8c62ae7954cfe13b621f. Not
sure what I did or how, but the changes from the hotfix branch got lost.
Redoing the merge to fix the problem.
|
|
The PHP native `$php_errormsg` variable has been deprecated as of PHP
7.2. The recommended replacement is `error_get_last()`.
A number of the driver classes used `$php_errormsg` to track if a DB
action caused an error.
As the `error_get_last()` function returns an array and comparing the
message therefore is slightly more involved, two new methods have been
introduced into the abstract parent class `ADOConnection` to handle the
message comparison.
The `resetLastError()` method retrieves the initial (old) error message
and resets it to enable checking whether a new error has occurred, even
when the new error is the same as the previous one.
The new `getChangedErrorMsg()` method compares the old error message
with the current one to determine whether a new message has occurred,
and if so, returns the message.
Refs:
* http://php.net/manual/en/migration72.deprecated.php#migration72.deprecated.track_errors-and-php_errormsg
* http://php.net/manual/en/reserved.variables.phperrormsg.php
* http://php.net/manual/en/function.error-get-last.php
Additional notes:
* In the `ADODB_ads::UpdateBlob()` method, the original (old) message
was not being retrieved which could result in an unrelated error being
recorded. This has been fixed.
* In the `ADODB_db2::_connect()` and `ADODB_db2::_pconnect()` methods,
the `$php_errormsg` was being reset, but subsequently not checked for
changes, so as the variable in effect was not being used, I've removed
the related code.
* In the `ADODB_sybase::ErrorMsg()` method, the `$php_errormsg` was
being checked, but no functions which could potential cause errors are
being called. As `$php_errormsg` is only available in the scope an
error occurred in, this meant that `$php_errormsg` would always be
empty, so I've removed the related code.
Fixes #409
|
|
|
|
Reserved variable $php_errormsg is deprecated in PHP 7.2
http://php.net/manual/en/reserved.variables.phperrormsg.php
Fixes #405
|
|
|
|
|
|
Fixes #371
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Changes from original pull request:
- suppress errors in _connect() also
- commit message reworded
|
|
Fixes #278
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fixes #171
|
|
|
|
|
|
|
|
- running SED script
- manual adjustments for files not processed by regex
|
|
This is the original commit from @valioz, rebased on latest master
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Conflicts:
drivers/adodb-db2ora.inc.php
drivers/adodb-mssqlpo.inc.php
drivers/adodb-odbc_oracle.inc.php
|