summaryrefslogtreecommitdiff
path: root/drivers
AgeCommit message (Collapse)AuthorFilesLines
2015-06-25Move _updatefields() method to ADORecordSetDamien Regad2-63/+0
Currently, this method only exists in postgres7, oci8 and derived drivers. Moving it to the base class will enable reuse by other drivers that need the functionality.
2015-06-25New method ADORecordSet::AssocCaseConvertFunction()Damien Regad1-9/+12
- Avoid code duplication - optimize ADORecordSet_assoc_postgres7::_updatefields()
2015-06-25Coding guidelines and whitespaceDamien Regad3-4/+11
2015-06-25Consistent GetRowAssoc() parameter default valueDamien Regad3-3/+3
MySQL and PostgreSQL used TRUE instead of ADODB_ASSOC_CASE.
2015-06-25Remove useless parameter in GetRowAssoc() callsDamien Regad7-12/+12
Because of the change in default value for the method's parameter, it is no longer needed to specify the constant when calling GetRowAssoc() in the individual drivers.
2015-06-25oci8: driver honors ADODB_ASSOC_CASE when fetching fieldsDamien Regad2-24/+50
This allows use of lowercase field names when executing queries in ADODB_FETCH_ASSOC fetch mode. The _updatefields() method was moved from oci8po to parent oci8 driver. - code was simplified - logic to determine if the operating in associative mode was moved from the callers to the method itself to reduce code duplication. - use of defined ADODB_ASSOC_CASE_* constants Fixes Github #21
2015-06-17PDO: fix broken FetchField functionDamien Regad1-3/+2
Coding guidelines changes actually altered the function's logic by replacing an if/elseif block by a non-equivalent switch statement. Regression introduced by a36f5c4276f7bbf8fc79039a950b0c68d06d2099. Fixes #121, #122
2015-05-21mssqlnative: fix insert_ID() fails if server returns more than 1 rowgitjti1-3/+4
If inserting involves trigger action, SQL server probably returns more than result ”rows” and we are interested in last one only. Fixes #41, PR #102 Signed-off-by: Damien Regad <dregad@mantisbt.org>
2015-05-21mssqlnative: use correct setting 'WarningsReturnAsErrors'Ray Morris1-2/+2
The driver called sqlsrv_configure('warnings_return_as_errors', 0), which throws "error code = -14, sqlsrv_configure: message = An invalid parameter was passed to sqlsrv_configure". The proper setting is 'WarningsReturnAsErrors', as per documentation http://php.net/manual/en/function.sqlsrv-configure.php Fixes #103 Signed-off-by: Damien Regad <dregad@mantisbt.org> Referenced the fix in the changelog
2015-05-15sqlite3: Fix result-less SQL statements executed twiceDamien Regad2-2/+12
The sqlite3 driver relies on SQLite3::query to execute the statement, which returns an empty SQLite3Result while the ADOConnection::_Execute() method expects true for handling of result-less queries. This causes the query to be executed a second time when ADOdb initializes the recordset for what it wrongly assumes to be a SELECT statement. This also addresses the same behavior with the sqlite driver, but the fix was not tested as I don't have a sqlite 2 setup available. Fixes #99
2015-05-15MSSQL: fix fail on insert when statement contains ';'stekule1-1/+1
In mssql a tick mark (') in a value string is escaped via a second one. Therefore the number of tick marks before the semicolon must be odd (since the string starts with a tick mark). Semicolons should be allowed after an odd number of tick marks. There must be a character between the odd tick mark groups. Fixes #97, see also #96
2015-05-15Use ADODB_ASSOC_CASE_xxx constantsDamien Regad2-13/+14
2015-05-15Coding guidelines and whitespaceDamien Regad2-144/+174
2015-05-04Coding guidelines and whitespaceDamien Regad2-157/+363
2015-05-04Remove unused, useless and commented out codeDamien Regad2-82/+1
2015-04-20Fix PHP noticesDamien Regad1-0/+2
2015-04-20Whitespace and coding guidelinesDamien Regad2-140/+257
2015-04-20dsn/connection support for sqlsrvMarcelTO1-1/+13
2015-04-20added driver for pdo sqlsrvMarcelTO1-0/+49
2015-04-20Remove uncessary silencerMike Benoit1-1/+1
2015-04-20Use pg_query() instead of pg_exec()Mike Benoit1-17/+17
pg_exec() is a legacy alias for pg_query() [1]. Replace it when the query is not prepared, or use pg_execute() when it is. This fixes issues with HHVM v3.6. [1] http://php.net/manual/en/function.pg-query.php Signed-off-by: Damien Regad <dregad@mantisbt.org> Mike's original commit was split into distinct elements.
2015-04-20Fix whitespace / commentsMike Benoit1-8/+9
Signed-off-by: Damien Regad <dregad@mantisbt.org> Mike's original commit was split into distinct elements.
2015-04-20Replace pg_cmdtuples() alias by pg_affected_rows()Damien Regad1-3/+1
2015-03-05WhitespaceDamien Regad1-181/+185
2015-03-04Fix qstr() when called without an active connection.Damien Regad1-1/+3
mysqli_real_escape_string(), differs from mysql_real_escape_string(). The former requires a valid mysqli DB connection object, while the latter has a fallback mechanism which attempts to generate a connection when given NULL. When calling ADOConnection::qstr() without an active connection ($_connectionID == false), mysqli_real_escape_string() throws a warning and returns an empty string. Now, we fallback to pre-PHP 5 mechanism to quote the string when not connected. Fixes #79
2015-03-04PHPDoc, whitespaceDamien Regad1-14/+16
2015-03-04pdo: align method signatures with parent classAndy Theuninck1-2/+2
ADODB_pdo_base MetaTables() and MetaColumns() now match the function definition in ADODB_pdo, to avoid PHP notices (Pull request #62). Signed-off-by: Damien Regad <dregad@mantisbt.org>
2015-03-04SQLite: fix typo of $this for _connectazghanvi1-1/+1
Signed-off-by: Damien Regad <dregad@mantisbt.org>
2014-10-29SQLite3: fix _pconnect()Damien Regad1-14/+3
There is no permanent connection in SQLite3, so we just call _connect()
2014-10-29SQLite3: Fix #51 wrong connection parameterDamien Regad1-3/+3
Thanks to diogotoscano
2014-10-29SQLite3: ServerInfo() now returns driver versionDamien Regad1-2/+3
2014-10-29SQLite3: Fix #53: FetchField column nameDamien Regad1-1/+1
Thanks to @diogotoscano
2014-10-29SQLite/SQLite3: Coding guidelines, whitespaceDamien Regad2-190/+294
2014-10-29SQLite3 does not implement seekDamien Regad1-1/+5
The _seek() method now returns false and outputs a warning in debug mode
2014-10-29SQLite3: remove useless commentsDamien Regad2-50/+0
2014-10-29Add missing property ADODB_pdo::$_driverFrederik Bosch1-0/+1
Fixes #56 Signed-off-by: Damien Regad <dregad@mantisbt.org>
2014-09-26Coding guidelines / whitespaceDamien Regad1-102/+122
2014-09-26ADODB_pdo_mysql: add functionality from ADODB_mysqlAndy Theuninck1-1/+98
* SQLDate method for generating date formatting strings * SelectDB method for changing selected database * $metaTablesSQL string that includes table vs view detection Makes pdo_mysql behave more similarly to mysql and mysqli. Swapping underlying driver becomes easier. Signed-off-by: Damien Regad <dregad@mantisbt.org> Original commit modified to fix whitespace
2014-09-09pgsql: more occurences of legacy aliasesDamien Regad2-9/+9
2014-09-09pgsql: Stop using legacy function aliasesMikeB2-9/+9
Use proper PostgreSQL function names rather than legacy aliases that arent documented anymore. This should continue to work back to PHP v4.2 still, and also works with HHVM. Signed-off-by: Damien Regad <dregad@mantisbt.org>
2014-09-09Work around minor differences in HHVM behavior for MySQL.MikeB1-2/+7
2014-09-09WhitespaceDamien Regad2-471/+456
2014-09-09mysql: prevent race conditions when creating/dropping sequencesDamien Regad1-2/+2
The fix implemented in 4ff57e224bdc1969e0618201569c8d866e58bca9 for mysqli applies to mysql driver also. Fixes #28
2014-09-09mysqli: prevent race conditions when creating/dropping sequencesMikeB1-2/+2
Add IF EXISTS/IF NOT EXISTS to MySQL commands when creating/dropping sequence tables. This prevents race conditions that can be easily triggered in unit tests running in parallel. Fixes #28 Signed-off-by: Damien Regad <dregad@mantisbt.org>
2014-05-13Fix indentationDamien Regad1-22/+25
2014-05-12postgres7: fix system warning in MetaColumns() with schemaDamien Regad2-3/+33
When calling MetaColumns with schema.table, the driver triggers a 'Warning: sprintf(): Too few arguments' because the metaColumnsSQL1 statement contains one more parameter in 7 compared to the 6.4 version. Resolved by adding a new protected _generateMetaColumnsSQL() method to handle the preparation of the appropriate SQL statement, and overriding it in the postgres7 driver. http://phplens.com/lens/lensforum/msgs.php?id=19481
2014-05-12mssqlnative: replace error_log() calls with ADOConnection::outp()Damien Regad1-27/+27
Fixes #12
2014-05-12WhitespaceDamien Regad1-14/+14
2014-04-30Add phpDocDamien Regad1-0/+3
2014-04-30Simplify SQL in postgres7 MetaForeignKeysDamien Regad1-41/+22
The original SQL from William Kolodny [William.Kolodny#gt-t.net] was very complex with multiple sub-select statements. Through use of regexp_replace() instead of split_part(), we now have only a single subquery. Removed obsolete comment.