| Age | Commit message (Collapse) | Author | Files | Lines |
|
Currently, this method only exists in postgres7, oci8 and derived
drivers. Moving it to the base class will enable reuse by other drivers
that need the functionality.
|
|
- Avoid code duplication
- optimize ADORecordSet_assoc_postgres7::_updatefields()
|
|
|
|
MySQL and PostgreSQL used TRUE instead of ADODB_ASSOC_CASE.
|
|
Because of the change in default value for the method's parameter, it is
no longer needed to specify the constant when calling GetRowAssoc() in
the individual drivers.
|
|
This allows use of lowercase field names when executing queries in
ADODB_FETCH_ASSOC fetch mode.
The _updatefields() method was moved from oci8po to parent oci8 driver.
- code was simplified
- logic to determine if the operating in associative mode was moved from
the callers to the method itself to reduce code duplication.
- use of defined ADODB_ASSOC_CASE_* constants
Fixes Github #21
|
|
Coding guidelines changes actually altered the function's logic by
replacing an if/elseif block by a non-equivalent switch statement.
Regression introduced by a36f5c4276f7bbf8fc79039a950b0c68d06d2099.
Fixes #121, #122
|
|
If inserting involves trigger action, SQL server probably returns more
than result ”rows” and we are interested in last one only.
Fixes #41, PR #102
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
The driver called sqlsrv_configure('warnings_return_as_errors', 0),
which throws "error code = -14, sqlsrv_configure: message = An invalid
parameter was passed to sqlsrv_configure".
The proper setting is 'WarningsReturnAsErrors', as per documentation
http://php.net/manual/en/function.sqlsrv-configure.php
Fixes #103
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Referenced the fix in the changelog
|
|
The sqlite3 driver relies on SQLite3::query to execute the statement,
which returns an empty SQLite3Result while the ADOConnection::_Execute()
method expects true for handling of result-less queries. This causes the
query to be executed a second time when ADOdb initializes the recordset
for what it wrongly assumes to be a SELECT statement.
This also addresses the same behavior with the sqlite driver, but the
fix was not tested as I don't have a sqlite 2 setup available.
Fixes #99
|
|
In mssql a tick mark (') in a value string is escaped via a second one.
Therefore the number of tick marks before the semicolon must be odd
(since the string starts with a tick mark).
Semicolons should be allowed after an odd number of tick marks.
There must be a character between the odd tick mark groups.
Fixes #97, see also #96
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
pg_exec() is a legacy alias for pg_query() [1]. Replace it when the
query is not prepared, or use pg_execute() when it is.
This fixes issues with HHVM v3.6.
[1] http://php.net/manual/en/function.pg-query.php
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Mike's original commit was split into distinct elements.
|
|
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Mike's original commit was split into distinct elements.
|
|
|
|
|
|
mysqli_real_escape_string(), differs from mysql_real_escape_string().
The former requires a valid mysqli DB connection object, while the
latter has a fallback mechanism which attempts to generate a connection
when given NULL.
When calling ADOConnection::qstr() without an active connection
($_connectionID == false), mysqli_real_escape_string() throws a warning
and returns an empty string.
Now, we fallback to pre-PHP 5 mechanism to quote the string when not
connected.
Fixes #79
|
|
|
|
ADODB_pdo_base MetaTables() and MetaColumns() now match the function
definition in ADODB_pdo, to avoid PHP notices (Pull request #62).
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
There is no permanent connection in SQLite3, so we just call _connect()
|
|
Thanks to diogotoscano
|
|
|
|
Thanks to @diogotoscano
|
|
|
|
The _seek() method now returns false and outputs a warning in debug mode
|
|
|
|
Fixes #56
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
|
|
* SQLDate method for generating date formatting strings
* SelectDB method for changing selected database
* $metaTablesSQL string that includes table vs view detection
Makes pdo_mysql behave more similarly to mysql and mysqli. Swapping
underlying driver becomes easier.
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Original commit modified to fix whitespace
|
|
|
|
Use proper PostgreSQL function names rather than legacy aliases that
arent documented anymore. This should continue to work back to PHP v4.2
still, and also works with HHVM.
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
|
|
|
|
The fix implemented in 4ff57e224bdc1969e0618201569c8d866e58bca9 for
mysqli applies to mysql driver also.
Fixes #28
|
|
Add IF EXISTS/IF NOT EXISTS to MySQL commands when creating/dropping
sequence tables. This prevents race conditions that can be easily
triggered in unit tests running in parallel.
Fixes #28
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
|
|
When calling MetaColumns with schema.table, the driver triggers a
'Warning: sprintf(): Too few arguments' because the metaColumnsSQL1
statement contains one more parameter in 7 compared to the 6.4 version.
Resolved by adding a new protected _generateMetaColumnsSQL() method to
handle the preparation of the appropriate SQL statement, and overriding
it in the postgres7 driver.
http://phplens.com/lens/lensforum/msgs.php?id=19481
|
|
Fixes #12
|
|
|
|
|
|
The original SQL from William Kolodny [William.Kolodny#gt-t.net] was
very complex with multiple sub-select statements.
Through use of regexp_replace() instead of split_part(), we now have
only a single subquery.
Removed obsolete comment.
|