| Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
- running SED script
- manual adjustments for files not processed by regex
|
|
function, the query has already been closed
|
|
https://github.com/ADOdb/ADOdb/pull/158
|
|
This relies on the superclass's built-in default of $this->_numOfRows
being set to -1. That causes the sqlite3 driver to rely on
ADODB_COUNTRECS.
Before this patch, we were setting _numOfRows to positive 1, which meant
that any query that checked how many rows were available in a queryset
would see literally the number 1, which was not accurate for queries that
returned 0 rows or queries that returned more rows.
In the case of sqlite3, there appears to be no efficient way to ask the
PHP sqlite3 driver how many rows come back from a query, so relying on
ADODB_COUNTRECS is the best we can do.
|
|
reference issue adodb/adodb/issues/117
|
|
Documentation fix as requested in ADOdb/ADOdb/issues/117
|
|
Update to documentation as requested in ADOdb/ADOdb/issues/117
|
|
Documentation update requested in ADOdb/ADOdb/issues/117
|
|
Saves one query for every connection when blobs arent being used.
Fixes #112
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Driver failed if a prepared statement was passed to _query(). This was because the _appendN method could only handle an input parameter that was a string . This method now accepts an array as the input parameter
|
|
This is the original commit from @valioz, rebased on latest master
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Conflicts:
drivers/adodb-db2ora.inc.php
drivers/adodb-mssqlpo.inc.php
drivers/adodb-odbc_oracle.inc.php
|
|
|
|
When processing an SQL statement containing a '?' character within a
string, ADOdb wrongly assumed it is for a bind variable. The number of
variables then no longer matches the number passed, and crashes the
_query() function.
We now identify whether a '?' is within a string and don't use it as a
bind variable if so.
Fixes #132
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
With this, the mysql and mysqli (and derived) drivers convert the
recordset field names to the case defined by ADODB_ASSOC_CASE.
Fixes #100
|
|
Currently, this method only exists in postgres7, oci8 and derived
drivers. Moving it to the base class will enable reuse by other drivers
that need the functionality.
|
|
- Avoid code duplication
- optimize ADORecordSet_assoc_postgres7::_updatefields()
|
|
|
|
MySQL and PostgreSQL used TRUE instead of ADODB_ASSOC_CASE.
|
|
Because of the change in default value for the method's parameter, it is
no longer needed to specify the constant when calling GetRowAssoc() in
the individual drivers.
|
|
This allows use of lowercase field names when executing queries in
ADODB_FETCH_ASSOC fetch mode.
The _updatefields() method was moved from oci8po to parent oci8 driver.
- code was simplified
- logic to determine if the operating in associative mode was moved from
the callers to the method itself to reduce code duplication.
- use of defined ADODB_ASSOC_CASE_* constants
Fixes Github #21
|
|
Coding guidelines changes actually altered the function's logic by
replacing an if/elseif block by a non-equivalent switch statement.
Regression introduced by a36f5c4276f7bbf8fc79039a950b0c68d06d2099.
Fixes #121, #122
|
|
If inserting involves trigger action, SQL server probably returns more
than result ”rows” and we are interested in last one only.
Fixes #41, PR #102
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
The driver called sqlsrv_configure('warnings_return_as_errors', 0),
which throws "error code = -14, sqlsrv_configure: message = An invalid
parameter was passed to sqlsrv_configure".
The proper setting is 'WarningsReturnAsErrors', as per documentation
http://php.net/manual/en/function.sqlsrv-configure.php
Fixes #103
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Referenced the fix in the changelog
|
|
The sqlite3 driver relies on SQLite3::query to execute the statement,
which returns an empty SQLite3Result while the ADOConnection::_Execute()
method expects true for handling of result-less queries. This causes the
query to be executed a second time when ADOdb initializes the recordset
for what it wrongly assumes to be a SELECT statement.
This also addresses the same behavior with the sqlite driver, but the
fix was not tested as I don't have a sqlite 2 setup available.
Fixes #99
|
|
In mssql a tick mark (') in a value string is escaped via a second one.
Therefore the number of tick marks before the semicolon must be odd
(since the string starts with a tick mark).
Semicolons should be allowed after an odd number of tick marks.
There must be a character between the odd tick mark groups.
Fixes #97, see also #96
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
pg_exec() is a legacy alias for pg_query() [1]. Replace it when the
query is not prepared, or use pg_execute() when it is.
This fixes issues with HHVM v3.6.
[1] http://php.net/manual/en/function.pg-query.php
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Mike's original commit was split into distinct elements.
|
|
Signed-off-by: Damien Regad <dregad@mantisbt.org>
Mike's original commit was split into distinct elements.
|
|
|
|
|
|
mysqli_real_escape_string(), differs from mysql_real_escape_string().
The former requires a valid mysqli DB connection object, while the
latter has a fallback mechanism which attempts to generate a connection
when given NULL.
When calling ADOConnection::qstr() without an active connection
($_connectionID == false), mysqli_real_escape_string() throws a warning
and returns an empty string.
Now, we fallback to pre-PHP 5 mechanism to quote the string when not
connected.
Fixes #79
|
|
|
|
ADODB_pdo_base MetaTables() and MetaColumns() now match the function
definition in ADODB_pdo, to avoid PHP notices (Pull request #62).
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
Signed-off-by: Damien Regad <dregad@mantisbt.org>
|
|
There is no permanent connection in SQLite3, so we just call _connect()
|
|
Thanks to diogotoscano
|
|
|
|
Thanks to @diogotoscano
|
|
|
|
The _seek() method now returns false and outputs a warning in debug mode
|
|
|