From 7cafbbfa3bd1b065dd4ea491252d586835f3456b Mon Sep 17 00:00:00 2001 From: Damien Regad Date: Sat, 22 Nov 2025 12:21:31 +0100 Subject: Remove useless strlen() and simplify quote check --- adodb-active-record.inc.php | 4 +--- adodb-active-recordx.inc.php | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/adodb-active-record.inc.php b/adodb-active-record.inc.php index 001d46d9..e3eb52c0 100644 --- a/adodb-active-record.inc.php +++ b/adodb-active-record.inc.php @@ -742,9 +742,7 @@ class ADODB_Active_Record { if ('' === (string)$val) { return "''"; } - if (strlen($val) > 0 && - (strncmp($val, "'", 1) != 0 || substr($val, strlen($val) - 1, 1) != "'") - ) { + if (substr($val, 0, 1) != "'" || substr($val,-1) != "'") { return $db->qstr($val); } default: diff --git a/adodb-active-recordx.inc.php b/adodb-active-recordx.inc.php index 079352f1..503d34dd 100644 --- a/adodb-active-recordx.inc.php +++ b/adodb-active-recordx.inc.php @@ -780,9 +780,7 @@ class ADODB_Active_Record { if ('' === (string)$val) { return "''"; } - if (strlen($val) > 0 && - (strncmp($val, "'", 1) != 0 || substr($val, strlen($val) - 1, 1) != "'") - ) { + if (substr($val, 0, 1) != "'" || substr($val,-1) != "'") { return $db->qstr($val); } default: -- cgit v1.3