From 93f13fd8e92ce7349ad84752c68235b252b88468 Mon Sep 17 00:00:00 2001 From: Matt Simpson Date: Thu, 10 Jan 2019 16:44:34 -0500 Subject: Remove session_module_name('user') calls These calls throw an error on PHP >= 7.2 "session_module_name(): Cannot set 'user' save handler by ini_set() or session_module_name()". They were previously silently ignored, but as per PHP documentation [1], since PHP 7.2.0 it is explicitly forbidden to set the module name to "user" so this commit removes the function calls from session-related files. Fixes #449 [1] http://php.net/session_module_name Improved commit message. Signed-off-by: Damien Regad --- session/adodb-session.php | 1 - session/adodb-session2.php | 1 - session/old/adodb-cryptsession.php | 1 - session/old/adodb-session-clob.php | 1 - session/old/adodb-session.php | 1 - 5 files changed, 5 deletions(-) (limited to 'session') diff --git a/session/adodb-session.php b/session/adodb-session.php index b8326086..811cb29f 100644 --- a/session/adodb-session.php +++ b/session/adodb-session.php @@ -442,7 +442,6 @@ class ADODB_Session { /*! */ function _init() { - session_module_name('user'); session_set_save_handler( array('ADODB_Session', 'open'), array('ADODB_Session', 'close'), diff --git a/session/adodb-session2.php b/session/adodb-session2.php index bb821782..ae5a9f78 100644 --- a/session/adodb-session2.php +++ b/session/adodb-session2.php @@ -464,7 +464,6 @@ class ADODB_Session { /*! */ static function _init() { - session_module_name('user'); session_set_save_handler( array('ADODB_Session', 'open'), array('ADODB_Session', 'close'), diff --git a/session/old/adodb-cryptsession.php b/session/old/adodb-cryptsession.php index 7836022d..62327102 100644 --- a/session/old/adodb-cryptsession.php +++ b/session/old/adodb-cryptsession.php @@ -302,7 +302,6 @@ function adodb_sess_gc($maxlifetime) { return true; } -session_module_name('user'); session_set_save_handler( "adodb_sess_open", "adodb_sess_close", diff --git a/session/old/adodb-session-clob.php b/session/old/adodb-session-clob.php index c633b613..cd41afba 100644 --- a/session/old/adodb-session-clob.php +++ b/session/old/adodb-session-clob.php @@ -426,7 +426,6 @@ function adodb_sess_gc($maxlifetime) return true; } -session_module_name('user'); session_set_save_handler( "adodb_sess_open", "adodb_sess_close", diff --git a/session/old/adodb-session.php b/session/old/adodb-session.php index 2385cc62..2cf445bb 100644 --- a/session/old/adodb-session.php +++ b/session/old/adodb-session.php @@ -417,7 +417,6 @@ function adodb_sess_gc($maxlifetime) return true; } -session_module_name('user'); session_set_save_handler( "adodb_sess_open", "adodb_sess_close", -- cgit v1.3