From 0d1b70c32970168711679b0f4621144f40a9caba Mon Sep 17 00:00:00 2001 From: Lester Caine Date: Mon, 1 Jun 2026 15:09:55 +0100 Subject: Fix uksort callbacks — use closures instead of namespaced string names MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit String callbacks with namespace prefixes are unreliable; fn() closures resolve upgrade_version_sort / upgrade_query_sort in the current namespace. Co-Authored-By: Claude Sonnet 4.6 --- includes/classes/BitInstaller.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/classes/BitInstaller.php b/includes/classes/BitInstaller.php index 75df5b1..b1db9f4 100755 --- a/includes/classes/BitInstaller.php +++ b/includes/classes/BitInstaller.php @@ -328,7 +328,7 @@ class BitInstaller extends BitSystem { public function upgradePackageVersions( $pPackage ) { if( !empty( $pPackage ) && !empty( $this->mPackageUpgrades[$pPackage] )) { // make sure everything is in the right order - uksort( $this->mPackageUpgrades[$pPackage], 'Bitweaver\Install\upgrade_version_sort' ); + uksort( $this->mPackageUpgrades[$pPackage], fn($a, $b) => upgrade_version_sort($a, $b) ); foreach( array_keys( $this->mPackageUpgrades[$pPackage] ) as $version ) { // version we are upgrading from @@ -539,7 +539,7 @@ class BitInstaller extends BitSystem { if( !empty( $sql ) ) $sql = null; break; case 'QUERY': - uksort( $step, 'Bitweaver\Install\upgrade_query_sort' ); + uksort( $step, fn($a, $b) => upgrade_query_sort($a, $b) ); foreach( array_keys( $step ) as $dbType ) { if( $dbType == 'MYSQL' && preg_match( '/mysql/', $gBitDbType )) { $sql = $step[$dbType]; -- cgit v1.3