liberty, branch master

Fix mContentTypeGuid never set after getLibertyObject load

2026-06-19T10:35:42Z

registerContentType() set mType and mPackageGuid but skipped mContentTypeGuid, leaving it null throughout the object lifetime when loaded via getLibertyObject. This caused a TypeError in xrefType() -> LibertyXrefType::__construct(string, ...). Co-Authored-By: Claude Sonnet 4.6

Fix pdfjs viewer URL: move zoom to hash, fix search hash parameter

2026-06-16T11:51:42Z

zoom=page-width was appended to the file URL; moved to viewer hash where pdfjs expects it. search= now correctly appended to the same hash fragment. Co-Authored-By: Claude Sonnet 4.6

Replace Add Comment text button with insert-text icon in non-AJAX path

2026-06-16T08:37:09Z

Co-Authored-By: Claude Sonnet 4.6

Replace network-receive with go-down for file download icon

2026-06-16T08:31:29Z

Co-Authored-By: Claude Sonnet 4.6

Replace Add Comment text button with insert-text icon

2026-06-16T08:28:48Z

Co-Authored-By: Claude Sonnet 4.6

Add CLAUDE.md with liberty xref machinery developer notes

2026-06-14T15:23:51Z

Covers LibertyXrefType, dual-guid schema, xref display path, parseDataHash, storeXref, owner change, Firebird GROUP BY. Co-Authored-By: Claude Sonnet 4.6

loadContent: add linked_data alongside linked_title from lc_linked JOIN

2026-06-12T15:13:26Z

Exposes liberty_content.data of the linked content item so BOM and other xref view templates can display description without a separate enrichment query. Co-Authored-By: Claude Sonnet 4.6

LibertyXref: propagate mPackageGuid so dual-guid types resolve correctly in load/verify; loadContent: add linked_title from joined liberty_content

2026-06-12T09:41:35Z

LibertyXref gains mPackageGuid; load() and verify() now use IN(contentTypeGuid,packageGuid) so package-level xref items (e.g. stock/supplier) are found when editing a sub-type record (e.g. stockcomponent). LibertyContent propagates mPackageGuid to LibertyXref in loadXref(), storeXref() and stepXref(). LibertyXrefType::loadContent() LEFT JOINs liberty_content on x.xref to expose linked_title for templates that display a linked content item's name. Co-Authored-By: Claude Sonnet 4.6

Consolidate xref loading: LibertyXrefInfo → LibertyXrefContent + LibertyXrefType::loadContent()

2026-06-11T13:14:36Z

- Add LibertyXrefContent: thin data container (just $mGroups), replaces LibertyXrefInfo - Delete LibertyXrefInfo: constructor params and load() move to LibertyXrefType::loadContent() - LibertyXrefType::loadContent($contentId): loads all display groups and their xref rows, returns LibertyXrefContent; absorbs both LibertyXrefInfo::load() and LibertyXrefGroup::loadXrefs() - LibertyXrefGroup: pure value object — remove extends LibertyBase, remove loadXrefs(); mXrefs type changed to LibertyXref[] - LibertyXref: add ArrayAccess + fromRow() factory; templates keep {$xrefInfo.key} dot notation unchanged; load() also populates $mRow for consistency - LibertyContent: mXrefInfo type updated to LibertyXrefContent; loadXrefInfo() delegates to $this->xrefType()->loadContent(); xrefType() visibility private → protected (StockBase calls it from an override) Co-Authored-By: Claude Sonnet 4.6

LibertyXref: extend BitBase directly, not LibertyBase

2026-06-11T12:43:50Z

Uses mDb and mErrors from BitBase; does not use any LibertyBase factory methods (getLibertyObject, getLibertyClass etc). BitBase is the correct base. Co-Authored-By: Claude Sonnet 4.6