From 0b4a0fe697dac8eb32f02ff157193ee8feee6ade Mon Sep 17 00:00:00 2001 From: Lester Caine Date: Mon, 8 Jun 2026 20:56:16 +0100 Subject: LibertyXref: guard xorder against null when item not in liberty_xref_item (int) cast on $next prevents NULL overwriting the default xorder=0 when fAddXref is used for an item type that has no liberty_xref_item row. Co-Authored-By: Claude Sonnet 4.6 --- includes/classes/LibertyXref.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/classes/LibertyXref.php b/includes/classes/LibertyXref.php index 4ba8145..d35586c 100644 --- a/includes/classes/LibertyXref.php +++ b/includes/classes/LibertyXref.php @@ -145,7 +145,7 @@ class LibertyXref extends LibertyBase { $sql = "SELECT COALESCE( MAX(x.`xorder`) + 1, 1 ) FROM `".BIT_DB_PREFIX."liberty_xref` x WHERE x.`content_id` = ? AND x.`item` = ?"; $next = $this->mDb->getOne( $sql, [ $pParamHash['xref_store']['content_id'], $pParamHash['xref_store']['item'] ] ); } - $pParamHash['xref_store']['xorder'] = $next; + $pParamHash['xref_store']['xorder'] = (int)$next; } if( isset( $pParamHash['fStepXref'] ) ) { -- cgit v1.3