summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Fowler <spider@viovio.com>2011-03-16 19:00:53 -0400
committerChristian Fowler <spider@viovio.com>2011-03-16 19:00:53 -0400
commitd731d86d299b4001b0ad34e5357717366cf1986c (patch)
tree72454134e08c9799528c0fa5c76f5b6a3d2be2ad
parentd862f8f9f5912aa2d20ef4ad069a8c33376eddf4 (diff)
downloadthemes-d731d86d299b4001b0ad34e5357717366cf1986c.tar.gz
themes-d731d86d299b4001b0ad34e5357717366cf1986c.tar.bz2
themes-d731d86d299b4001b0ad34e5357717366cf1986c.zip
fix module layout variable collision
-rw-r--r--admin/admin_layout_inc.php17
-rw-r--r--templates/admin_layout.tpl8
2 files changed, 18 insertions, 7 deletions
diff --git a/admin/admin_layout_inc.php b/admin/admin_layout_inc.php
index 025662d..f6d4b01 100644
--- a/admin/admin_layout_inc.php
+++ b/admin/admin_layout_inc.php
@@ -93,9 +93,20 @@ $layoutHash = array(
'layout' => $_REQUEST['module_package'],
'fallback' => FALSE,
);
-$layout = $gBitThemes->getLayout( $layoutHash );
-$gBitThemes->generateModuleNames( $layout );
-$gBitSmarty->assign_by_ref( 'layout', $layout );
+$editLayout = $gBitThemes->getLayout( $layoutHash );
+$gBitThemes->generateModuleNames( $editLayout );
+$gBitSmarty->assign( 'editLayout', $editLayout );
+
+$combinedList = array_merge( array_keys( $gBitSystem->mPackages ), array_keys( $allLayouts ) );
+$layoutList = array();
+foreach( $combinedList as $l ) {
+ $layoutList[$l] = $l;
+ if( isset( $allLayouts[$l] ) ) {
+ $layoutList[$l] .= ' *';
+ }
+}
+asort( $layoutList );
+$gBitSmarty->assign( 'layoutList', $layoutList );
if( $gBitSystem->isFeatureActive( 'site_top_column' )) {
$layoutAreas['top'] = 't';
diff --git a/templates/admin_layout.tpl b/templates/admin_layout.tpl
index d6690ea..e7fd919 100644
--- a/templates/admin_layout.tpl
+++ b/templates/admin_layout.tpl
@@ -7,12 +7,12 @@
{formlabel label="Customized layout" for="module_package"}
{forminput}
<select name="module_package" id="module_package" onchange="this.form.submit();">
- {foreach key=layoutName item=layout from=$gBitThemes->getAllLayouts()}
+ {foreach key=layoutName item=layoutDisplay from=$layoutList}
<option value="{$layoutName}" {if $module_package == $layoutName}selected="selected"{/if}>
{if $layoutName eq 'kernel'}
{tr}Site Default{/tr}
{else}
- {tr}{$layoutName|capitalize}{/tr}
+ {tr}{$layoutDisplay|capitalize}{/tr}
{/if}
</option>
{/foreach}
@@ -66,10 +66,10 @@
<tr>
<th>{tr}{$colkey} area{/tr}</th>
</tr>
- {section name=ix loop=$layout.$area}
+ {section name=ix loop=$editLayout.$area}
<tr>
<td>
- {include file="bitpackage:themes/module_config_inc.tpl" modInfo=$layout.$area[ix] condensed=1}
+ {include file="bitpackage:themes/module_config_inc.tpl" modInfo=$editLayout.$area[ix] condensed=1}
</td>
</tr>
{sectionelse}