From 72f9d187d8412a2502651646679d35c46ef70181 Mon Sep 17 00:00:00 2001
From: Lester Caine <lester@lsces.co.uk>
Date: Sat, 30 May 2026 17:52:48 +0100
Subject: Fix role_permissions nav bar dots and package filter on save
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Package filter links wrapped in <ul class="list-inline"> so <li> elements
are valid HTML — previously <li> inside <p> caused bullets to detach.

Hidden package field default changed from 'All' to '' so form submission
does not filter permissions to an empty set and silently save nothing.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 templates/admin_role_permissions.tpl | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/templates/admin_role_permissions.tpl b/templates/admin_role_permissions.tpl
index f814237..6075438 100755
--- a/templates/admin_role_permissions.tpl
+++ b/templates/admin_role_permissions.tpl
@@ -8,16 +8,16 @@
 		{formfeedback hash=$feedback}
 
 		{form}
-			<input type="hidden" name="package" value="{$smarty.request.package|default:'All'}" />
+			<input type="hidden" name="package" value="{$smarty.request.package}" />
 
-			<p>
-				{smartlink ititle=All package=$packageKey}
+			<ul class="list-inline">
+				<li>{smartlink ititle=All}</li>
 				{foreach from=$permPackages key=i item=packageKey}
 					{if $gBitSystem->isPackageActive($packageKey)}
-						&nbsp;&bull; {smartlink ititle=$gBitSystem->mPackages.$packageKey.name|default:$packageKey package=$packageKey}
+						<li>&bull; {smartlink ititle=$gBitSystem->mPackages.$packageKey.name|default:$packageKey package=$packageKey}</li>
 					{/if}
 				{/foreach}
-			</p>
+			</ul>
 
 			<table class="table data">
 				<caption>{tr}Available Permissions{/tr}</caption>
-- 
cgit v1.3