diff options
| author | Christian Fowler <spider@viovio.com> | 2009-01-06 18:07:32 +0000 |
|---|---|---|
| committer | Christian Fowler <spider@viovio.com> | 2009-01-06 18:07:32 +0000 |
| commit | 44343bf1f6fb7e4c0a1615e1768454484ac9971b (patch) | |
| tree | abec833200491c2bc7809eff6eb94ea73134356a /javascript | |
| parent | 4c688ebee272753efca634cae1272303fbe4b5f1 (diff) | |
| download | util-44343bf1f6fb7e4c0a1615e1768454484ac9971b.tar.gz util-44343bf1f6fb7e4c0a1615e1768454484ac9971b.tar.bz2 util-44343bf1f6fb7e4c0a1615e1768454484ac9971b.zip | |
remove use of $ alias in setFlip functions (which has conflicting implementations in jQuery vs. everyone else, so use document.getElementById, also check the flipperName id actually exists before try to flip things
Diffstat (limited to 'javascript')
| -rw-r--r-- | javascript/bitweaver.js | 38 |
1 files changed, 21 insertions, 17 deletions
diff --git a/javascript/bitweaver.js b/javascript/bitweaver.js index a0af087..3934ec6 100644 --- a/javascript/bitweaver.js +++ b/javascript/bitweaver.js @@ -1,4 +1,4 @@ -// $Header: /cvsroot/bitweaver/_bit_util/javascript/bitweaver.js,v 1.35 2008/12/20 22:03:32 tekimaki_admin Exp $ +// $Header: /cvsroot/bitweaver/_bit_util/javascript/bitweaver.js,v 1.36 2009/01/06 18:07:32 spiderr Exp $ // please modify this file and leave plenty of comments. This file will be // compressed automatically. Please make sure you only use comments beginning @@ -808,14 +808,16 @@ function setFlipIcon(elementId) { // date: Pre-bitweaver // params: elementId = a HTML Id function flipWithSign(elementId,cookie) { - var flipperName = "flipper" + elementId; - if ($(elementId).style.display == "none") { - showById(elementId,cookie); - $(flipperName).firstChild.nodeValue = "[-]"; - } else { - hideById(elementId,cookie); - $(flipperName).firstChild.nodeValue = "[+]"; -} } + if( flipperEle = document.getElementById( "flipper"+elementId ) ) { + if ($(elementId).style.display == "none") { + showById(elementId,cookie); + flipperEle.firstChild.nodeValue = "[-]"; + } else { + hideById(elementId,cookie); + flipperEle.firstChild.nodeValue = "[+]"; + } + } +} // function: setFlipWithSign // desc: Toggles the state of a flipped List after page reload @@ -823,14 +825,16 @@ function flipWithSign(elementId,cookie) { // date: Pre-bitweaver // params: elementId = a HTML Id of a List function setFlipWithSign(elementId) { - var flipperName = "flipper" + elementId; - if (getCookie(elementId) == "o") { - showById(elementId); - $(flipperName).firstChild.nodeValue = "[-]"; - } else { - hideById(elementId); - $(flipperName).firstChild.nodeValue = "[+]"; -} } + if( flipperEle = document.getElementById( "flipper"+elementId ) ) { + if (getCookie(elementId) == "o") { + showById(elementId); + flipperEle.firstChild.nodeValue = "[-]"; + } else { + hideById(elementId); + flipperEle.firstChild.nodeValue = "[+]"; + } + } +} // function: setCookieArray // desc: Creates a cookie if required and sets the element in the array |