diff options
| author | Mark Newnham <mark@newnhams.com> | 2018-08-05 10:30:12 -0600 |
|---|---|---|
| committer | Mark Newnham <mark@newnhams.com> | 2018-08-05 10:30:12 -0600 |
| commit | 980aa9965bfabddc0eb0be5dfc1fcf3c73899e8b (patch) | |
| tree | 87291835100e9b350413835769bcbda4bb1b2f1e | |
| parent | 171c1040a0cc52b8fa242987fb2f0215793e87c6 (diff) | |
| download | adodb-980aa9965bfabddc0eb0be5dfc1fcf3c73899e8b.tar.gz adodb-980aa9965bfabddc0eb0be5dfc1fcf3c73899e8b.tar.bz2 adodb-980aa9965bfabddc0eb0be5dfc1fcf3c73899e8b.zip | |
_adodb_getcount was not SQL Server Compliant See #423
SQL Server requires an alias when creating a count statement.
This true for Native Mode(mssqlnative), mssql and PDO drivers
| -rw-r--r-- | adodb-lib.inc.php | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/adodb-lib.inc.php b/adodb-lib.inc.php index e28db133..b0ec8230 100644 --- a/adodb-lib.inc.php +++ b/adodb-lib.inc.php @@ -423,14 +423,16 @@ function _adodb_getcount(&$zthis, $sql,$inputarr=false,$secs2cache=0) } else $rewritesql = "SELECT COUNT(*) FROM (".$rewritesql.")"; - } else if (strncmp($zthis->databaseType,'postgres',8) == 0 - || strncmp($zthis->databaseType,'mysql',5) == 0 - || strncmp($zthis->databaseType,'mssql',5) == 0 - ) { - $rewritesql = "SELECT COUNT(*) FROM ($rewritesql) _ADODB_ALIAS_"; - } else { - $rewritesql = "SELECT COUNT(*) FROM ($rewritesql)"; - } + } else if (strncmp($zthis->databaseType,'postgres',8) == 0 + || strncmp($zthis->databaseType,'mysql',5) == 0 + || strncmp($zthis->databaseType,'mssql',5) == 0 + || strncmp($zthis->dsnType,'sqlsrv',5) == 0 + || strncmp($zthis->dsnType,'mssql',5) == 0 + ){ + $rewritesql = "SELECT COUNT(*) FROM ($rewritesql) _ADODB_ALIAS_"; + } else { + $rewritesql = "SELECT COUNT(*) FROM ($rewritesql)"; + } } else { // now replace SELECT ... FROM with SELECT COUNT(*) FROM if ( strpos($sql, '_ADODB_COUNT') !== FALSE ) { |