I had forgotten that the medw site has a lot of articles which have not been displayed recently, so have applied all the Smarty5 and PHP8.4 fixes on mass which gets displaying and editing working, but the list function is currently broken

5 files changed, 14 insertions, 14 deletions

diff --git a/templates/article_display.tpl b/templates/article_display.tpl
index ea05f21..b457631 100755
--- a/templates/article_display.tpl
+++ b/templates/article_display.tpl
@@ -15,7 +15,7 @@
 		{/if}
 		{*<a style="display:none;" href="{$smarty.const.ARTICLES_PKG_URL}print.php?article_id={$article.article_id}">{booticon iname="icon-print"  ipackage="icons"  iexplain=print}</a>*}
 		{if $gContent->hasUserPermission( 'p_articles_remove' )}
-			{smartlink ititle="Remove" ipackage=articles ifile="list.php" booticon="icon-trash" action=remove remove_article_id=$article.article_id status_id=$smarty.request.status_id}
+			{smartlink ititle="Remove" ipackage=articles ifile="list.php" booticon="icon-trash" action=remove remove_article_id=$article.article_id status_id=$smarty.request.status_id|default:0}
 		{/if}
 	</div><!-- end .footer -->
 
@@ -72,7 +72,7 @@
 			{if $showDescriptionsOnly}
 				{$article.parsed_description}
 			{else}
-				{$article.parsed}
+				{$article.parsed_data}
 			{/if}
 		</div>
 
diff --git a/templates/center_list_articles.php b/templates/center_list_articles.php
index 2300e13..51c0607 100755
--- a/templates/center_list_articles.php
+++ b/templates/center_list_articles.php
@@ -2,9 +2,9 @@
 use Bitweaver\Users\RoleUser;
 
 global $gBitSmarty, $gBitSystem, $gQueryUserId, $moduleParams, $gContent;
-if ( !empty( $moduleParams ) ) {
-	extract( $moduleParams );
-}
+//if ( !empty( $moduleParams->value ) ) {
+//	extract( $moduleParams->value );
+//}
 
 
 include_once( ARTICLES_PKG_INCLUDE_PATH.'lookup_article_inc.php' );
@@ -27,9 +27,9 @@ if ( !empty( $_REQUEST['topic'] ) ) {
 	$gBitSmarty->assign( 'topic', $_REQUEST['topic'] );
 }
 
-if ( !empty( $moduleParams )) {
-	$listHash = array_merge( $_REQUEST, $moduleParams['module_params'] );
-	$listHash['max_records'] = $module_rows;
+if ( !empty( $moduleParams->value )) {
+	$listHash = array_merge( $_REQUEST, $moduleParams->value );
+	$listHash['max_records'] = $module_rows ?? 0;
 	//$listHash['parse_data'] = TRUE;
 	//$listHash['load_comments'] = TRUE;
 } else {
diff --git a/templates/center_list_articles.tpl b/templates/center_list_articles.tpl
index 1531e1b..41fe4cc 100755
--- a/templates/center_list_articles.tpl
+++ b/templates/center_list_articles.tpl
@@ -5,7 +5,7 @@
 		</div>
 	{/if}
 
-	{formfeedback success=$smarty.request.feedback}
+	{formfeedback success=$smarty.request.feedback|default:''}
 
 	{include file="bitpackage:articles/article_filter_inc.tpl"}
 	{if $gBitUser->hasPermission( 'p_articles_admin' ) && $futures}
diff --git a/templates/edit_article.tpl b/templates/edit_article.tpl
index b64caaf..6f27f40 100755
--- a/templates/edit_article.tpl
+++ b/templates/edit_article.tpl
@@ -22,14 +22,14 @@
 	{/if}
 
 	{formfeedback hash=$feedback}
-	{formfeedback warning=$errors.title}
+	{formfeedback warning=$errors.title|default:''}
 
 	<div class="body">
 		{form enctype="multipart/form-data" id="writearticle"}
 			<input type="hidden" name="article_id" value="{$gContent->mArticleId}" />
 			<input type="hidden" name="content_id" value="{$gContent->getField('content_id')}" />
-			<input type="hidden" name="preview_image_url" value="{$article.preview_image_url}" />
-			<input type="hidden" name="preview_image_path" value="{$article.preview_image_path}" />
+			<input type="hidden" name="preview_image_url" value="{$article.preview_image_url|default:''}" />
+			<input type="hidden" name="preview_image_path" value="{$article.preview_image_path|default:''}" />
 
 			{jstabs}
 				{jstab title="Article Body"}
@@ -118,7 +118,7 @@
 						{if $gBitSystem->isFeatureActive( 'articles_submissions_rnd_img' ) && !( $gContent->mArticleId || ( $gContent->hasUserPermission('p_articles_approve_submission') || $gContent->hasUserPermission('p_articles_auto_approve') ) )}
 							<hr />
 							{formfeedback error=$errors.captcha}
-							{captcha force=true variant=row}
+							{* captcha force=true variant=row *}
 						{/if}
 
 						<div class="form-group submit">
diff --git a/templates/list_articles.tpl b/templates/list_articles.tpl
index 24289da..a243f5b 100755
--- a/templates/list_articles.tpl
+++ b/templates/list_articles.tpl
@@ -25,7 +25,7 @@
 
 	<div class="body">
 
-		{formfeedback hash=$feedback}
+		{formfeedback hash=$feedback|default:''}
 
 		{include file="bitpackage:liberty/services_inc.tpl" serviceLocation='list_options'}