diff options
| author | Lester Caine <lester@lsces.co.uk> | 2026-05-21 17:01:35 +0100 |
|---|---|---|
| committer | Lester Caine <lester@lsces.co.uk> | 2026-05-21 17:01:35 +0100 |
| commit | 0ce4de7b6d05f675c8945ebb3af846f38272ef8b (patch) | |
| tree | bf17f19b738be5719bf4bb4241929c6323a42d0c | |
| parent | e26d182f402d8a5d0f7b0fcc7e5a149fac6bf9b7 (diff) | |
| download | fisheye-0ce4de7b6d05f675c8945ebb3af846f38272ef8b.tar.gz fisheye-0ce4de7b6d05f675c8945ebb3af846f38272ef8b.tar.bz2 fisheye-0ce4de7b6d05f675c8945ebb3af846f38272ef8b.zip | |
Fix broken parent gallery breadcrumb links; remove undefined changePhotoDrawer
changePhotoDrawer() was never defined — clicking a parent gallery in the breadcrumb
threw a JS error, return false never ran, and href="#" left the user on the same page
("links to self"). Replace with direct pretty URL navigation.
Also fix double-slash in gallery_nav.tpl (FISHEYE_PKG_URL already ends with /).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| -rwxr-xr-x | gallery_views/galleriffic/fisheye_galleriffic_inc_1.tpl | 2 | ||||
| -rwxr-xr-x | gallery_views/galleriffic/fisheye_galleriffic_inc_5.tpl | 2 | ||||
| -rwxr-xr-x | gallery_views/simple_list/fisheye_simple_list_inc.tpl | 2 | ||||
| -rwxr-xr-x | templates/gallery_nav.tpl | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/gallery_views/galleriffic/fisheye_galleriffic_inc_1.tpl b/gallery_views/galleriffic/fisheye_galleriffic_inc_1.tpl index 4e2160d..a1b4862 100755 --- a/gallery_views/galleriffic/fisheye_galleriffic_inc_1.tpl +++ b/gallery_views/galleriffic/fisheye_galleriffic_inc_1.tpl @@ -9,7 +9,7 @@ {if $breadCrumbs} {foreach from=$breadCrumbs item=breadTitle key=breadId} {if $breadId==$gContent->mGalleryId}<li class="active">{$breadTitle}</li> - {else}<li><a href="#" onclick="changePhotoDrawer('{$breadId}');return false;">{$breadTitle}</a></li>{/if} + {else}<li><a href="{$smarty.const.FISHEYE_PKG_URL}gallery/{$breadId}">{$breadTitle}</a></li>{/if} {/foreach} {/if} </ol> diff --git a/gallery_views/galleriffic/fisheye_galleriffic_inc_5.tpl b/gallery_views/galleriffic/fisheye_galleriffic_inc_5.tpl index 9ff6387..b9fc17f 100755 --- a/gallery_views/galleriffic/fisheye_galleriffic_inc_5.tpl +++ b/gallery_views/galleriffic/fisheye_galleriffic_inc_5.tpl @@ -10,7 +10,7 @@ {if $breadCrumbs} {foreach from=$breadCrumbs item=breadTitle key=breadId} {if $breadId==$gContent->mGalleryId}<li class="active">{$breadTitle}</li> - {else}<li><a href="#" onclick="changePhotoDrawer('{$breadId}');return false;">{$breadTitle}</a></li>{/if} + {else}<li><a href="{$smarty.const.FISHEYE_PKG_URL}gallery/{$breadId}">{$breadTitle}</a></li>{/if} {/foreach} {/if} </ol> diff --git a/gallery_views/simple_list/fisheye_simple_list_inc.tpl b/gallery_views/simple_list/fisheye_simple_list_inc.tpl index c0e6417..9536093 100755 --- a/gallery_views/simple_list/fisheye_simple_list_inc.tpl +++ b/gallery_views/simple_list/fisheye_simple_list_inc.tpl @@ -8,7 +8,7 @@ {if $breadCrumbs} {foreach from=$breadCrumbs item=breadTitle key=breadId} {if $breadId==$gContent->mGalleryId}<li class="active">{$breadTitle}</li> - {else}<li><a href="#" onclick="changePhotoDrawer('{$breadId}');return false;">{$breadTitle}</a></li>{/if} + {else}<li><a href="{$smarty.const.FISHEYE_PKG_URL}gallery/{$breadId}">{$breadTitle}</a></li>{/if} {/foreach} {/if} </ol> diff --git a/templates/gallery_nav.tpl b/templates/gallery_nav.tpl index 5447de9..e3fe66d 100755 --- a/templates/gallery_nav.tpl +++ b/templates/gallery_nav.tpl @@ -14,7 +14,7 @@ {if $breadCrumbs} {foreach from=$breadCrumbs item=breadTitle key=breadId} {if $breadId==$gContent->mGalleryId}<li class="active">{$breadTitle}</li> - {else}<li><a href="{$smarty.const.FISHEYE_PKG_URL}/gallery/{$breadId}">{$breadTitle}</a></li>{/if} + {else}<li><a href="{$smarty.const.FISHEYE_PKG_URL}gallery/{$breadId}">{$breadTitle}</a></li>{/if} {/foreach} {/if} </ol> |