Thought that this would fix an open transaction on Firebird, but something else

seems to have started a transaction when building nexus menues, so commit in
CompleteTransaction is not actioned until page closes

1 files changed, 2 insertions, 0 deletions

diff --git a/Nexus.php b/Nexus.php
index 9d4c041..843b857 100644
--- a/Nexus.php
+++ b/Nexus.php
@@ -236,6 +236,7 @@ class Nexus extends NexusSystem {
 	function storeMenu( &$pParamHash ) {
 		$ret = FALSE;
 		if( $this->verifyMenu( $pParamHash ) ) {
+			$this->mDb->StartTrans();
 			if( !@BitBase::verifyId( $pParamHash['menu_id'] ) ) {
 				$query = "INSERT INTO `".BIT_DB_PREFIX."nexus_menus`( `title`,`description`,`menu_type`,`plugin_guid`,`editable` ) VALUES(?,?,?,?,?)";
 				$result = $this->mDb->query( $query, array( $pParamHash['title'], $pParamHash['description'], $pParamHash['menu_type'], $pParamHash['plugin_guid'], $pParamHash['editable'] ) );
@@ -246,6 +247,7 @@ class Nexus extends NexusSystem {
 				$result = $this->mDb->query( $query, array( $pParamHash['title'], $pParamHash['description'], $pParamHash['menu_type'], $pParamHash['plugin_guid'], $pParamHash['editable'], $pParamHash['menu_id'] ) );
 				$ret = $pParamHash['menu_id'];
 			}
+			$this->mDb->CompleteTrans();
 			$this->writeMenuCache( $ret );
 		} else {
 			error_log( "Error storing menu: " . vc($this->mErrors) );