stock: remove gallery layout machinery — drop pagination constants, getLayout/getAllLayouts, per-page config, admin UI; simplify mod_components and display inc

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2 files changed, 1 insertions, 44 deletions

diff --git a/templates/admin_stock.tpl b/templates/admin_stock.tpl
index cc68dff..b02ab7d 100755
--- a/templates/admin_stock.tpl
+++ b/templates/admin_stock.tpl
@@ -1,18 +1,3 @@
-{literal}
-<script>//<![CDATA[
-function updateGalleryPagination() {
-	BitBase.hideById('fixed_grid-pagination');
-	BitBase.hideById('auto_flow-pagination');
-	BitBase.hideById('position_number-pagination');
-	BitBase.hideById('simple_list-pagination');
-
-	var input = document.getElementById('gallery-pagination');
-    var i  = input.selectedIndex;
-    var select = input.options[i].value;
-	BitBase.showById(select+'-pagination');
-}
-//]]></script>
-{/literal}
 {strip}
 
 {form}
@@ -84,29 +69,6 @@ function updateGalleryPagination() {
 				</div>
 			{/legend}
 
-			{legend legend="Default Assembly Display Settings"}
-				<div class="form-group">
-					{formhelp note="The settings below determine what the default display options will be set to for new assemblies."}
-				</div>
-
-				<div class="form-group">
-					{html_options id="gallery-pagination" name="default_gallery_pagination" id="gallery-pagination" options=$galleryPaginationTypes selected=$gBitSystem->getConfig('default_gallery_pagination',$smarty.const.STOCK_PAGINATION_FIXED_GRID) onchange="updateGalleryPagination();"}
-
-					<div id="fixed_grid-pagination">
-						<input type="text" id="gallery-rows-per-page" name="rows_per_page" size="2" maxlength="2" value="{$gBitSystem->getConfig('stock_gallery_default_rows_per_page')}"/> {tr}Rows per page{/tr}<br/>
-						<input type="text" id="gallery-cols-per-page" name="cols_per_page" size="2" maxlength="2" value="{$gBitSystem->getConfig('stock_gallery_default_cols_per_page')}"/> {tr}Columns per page{/tr}
-					</div>
-					<div id="auto_flow-pagination">
-						<input type="text" id="gallery-rows-per-page" name="total_per_page" size="2" maxlength="2" value="{$gBitSystem->getConfig('stock_gallery_default_rows_per_page')}"/> {tr}Total components per page{/tr}
-					</div>
-					<div id="position_number-pagination">
-						{formhelp note="Components are ordered by package group and position within the package. Use the Component Order page to assign positions."}
-					</div>
-					<div id="simple_list-pagination">
-						<input type="text" id="gallery-rows-per-page" name="lines_per_page" size="2" maxlength="2" value="{$gBitSystem->getConfig('stock_gallery_default_rows_per_page')}"/> {tr}Total lines per page{/tr}
-					</div>
-				</div>
-			{/legend}
 		{/jstab}
 
 		{jstab title="Components"}
@@ -133,6 +95,3 @@ function updateGalleryPagination() {
 {/form}
 
 {/strip}
-<script>//<![CDATA[
-updateGalleryPagination();
-//]]></script>
diff --git a/templates/view_assembly.tpl b/templates/view_assembly.tpl
index 07b7ff9..e3ebb94 100755
--- a/templates/view_assembly.tpl
+++ b/templates/view_assembly.tpl
@@ -1,7 +1,5 @@
-{assign var=galLayout value=$gContent->getLayout()}
 <div class="floaticon">
 	{if $gContent->hasUpdatePermission()}
-		{include file="bitpackage:liberty/services_inc.tpl" serviceLocation='icon' serviceHash=$gContent->mInfo}
 		<a title="{tr}Edit{/tr}" href="{$smarty.const.STOCK_PKG_URL}edit_assembly.php?content_id={$gContent->mContentId}">{biticon ipackage="icons" iname="edit" iexplain="Edit Assembly"}</a>
 		<a title="{tr}Component Order{/tr}" href="{$smarty.const.STOCK_PKG_URL}component_order.php?content_id={$gContent->mContentId}">{biticon ipackage="icons" iname="view-sort-ascending" iexplain="Component Order"}</a>
 	{/if}
@@ -12,7 +10,7 @@
 		<a title="{tr}Delete Assembly{/tr}" href="{$smarty.const.STOCK_PKG_URL}edit_assembly.php?content_id={$gContent->mContentId}&amp;delete=1">{biticon ipackage="icons" iname="user-trash" iexplain="Delete Assembly"}</a>
 	{/if}
 </div>
-{include file="`$smarty.const.STOCK_PKG_PATH`assembly_views/`$galLayout`/stock_`$galLayout`_inc.tpl"}
+{include file="bitpackage:stock/stock_simple_list_inc.tpl"}
 
 {if $gXrefInfo->mGroups}
 	{jstabs}