diff options
| author | Greg Roach <fisharebest@gmail.com> | 2014-10-24 22:17:49 +0100 |
|---|---|---|
| committer | Greg Roach <fisharebest@gmail.com> | 2014-10-24 22:17:49 +0100 |
| commit | e1f36e8a4903d2d3b863f66c6c2e18dc268abd39 (patch) | |
| tree | 8bbc15fb1fe627424a96838a26a5dc2500d98bf3 /admin_site_access.php | |
| parent | 4d83562e014f560f52e5779677856ad3a7e54e2f (diff) | |
| download | webtrees-e1f36e8a4903d2d3b863f66c6c2e18dc268abd39.tar.gz webtrees-e1f36e8a4903d2d3b863f66c6c2e18dc268abd39.tar.bz2 webtrees-e1f36e8a4903d2d3b863f66c6c2e18dc268abd39.zip | |
Do not use functions in loop conditions
Diffstat (limited to 'admin_site_access.php')
| -rw-r--r-- | admin_site_access.php | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/admin_site_access.php b/admin_site_access.php index 9b4897c98e..4404fe6845 100644 --- a/admin_site_access.php +++ b/admin_site_access.php @@ -72,21 +72,21 @@ case 'load_rules': $args[]=$search; } - $order = WT_Filter::get('order'); + $order = WT_Filter::getArray('order'); if ($order) { $sql .= ' ORDER BY '; - for ($i = 0; $i < count($order); ++$i) { - if ($i > 0) { + foreach ($order as $key => $value) { + if ($key > 0) { $sql .= ','; } // Datatables numbers columns 0, 1, 2, ... // MySQL numbers columns 1, 2, 3, ... - switch ($order[$i]['dir']) { + switch ($value['dir']) { case 'asc': - $sql .= (1 + $order[$i]['column']) . ' ASC '; + $sql .= (1 + $value['column']) . ' ASC '; break; case 'desc': - $sql .= (1 + $order[$i]['column']) . ' DESC '; + $sql .= (1 + $value['column']) . ' DESC '; break; } } @@ -151,21 +151,21 @@ case 'load_unknown': $args[] = $search; } - $order = WT_Filter::get('order'); + $order = WT_Filter::getArray('order'); if ($order) { $sql .= ' ORDER BY '; - for ($i = 0; $i < count($order); ++$i) { - if ($i > 0) { + foreach ($order as $key => $value) { + if ($key > 0) { $sql .= ','; } // Datatables numbers columns 0, 1, 2, ... // MySQL numbers columns 1, 2, 3, ... - switch ($order[$i]['dir']) { + switch ($value['dir']) { case 'asc': - $sql .= (1 + $order[$i]['column']) . ' ASC '; + $sql .= (1 + $value['column']) . ' ASC '; break; case 'desc': - $sql .= (1 + $order[$i]['column']) . ' DESC '; + $sql .= (1 + $value['column']) . ' DESC '; break; } } |