Fix: #4721 - concurrent edits can create duplicate XREFs

1 files changed, 2 insertions, 3 deletions

diff --git a/app/Factories/XrefFactory.php b/app/Factories/XrefFactory.php
index ea627dc0db..639b51fb88 100644
--- a/app/Factories/XrefFactory.php
+++ b/app/Factories/XrefFactory.php
@@ -49,13 +49,12 @@ class XrefFactory implements XrefFactoryInterface
     protected function generate(string $prefix, string $suffix): string
     {
         // Lock the row, so that only one new XREF may be generated at a time.
-        DB::table('site_setting')
+        $num = (int) DB::table('site_setting')
             ->where('setting_name', '=', 'next_xref')
             ->lockForUpdate()
-            ->get();
+            ->value('setting_value');
 
         $increment = 1.0;
-        $num       = (int) Site::getPreference('next_xref');
 
         do {
             $num += (int) $increment;