Make variable types clearer to static analysis tools

1 files changed, 5 insertions, 3 deletions

diff --git a/app/Http/RequestHandlers/PasteFact.php b/app/Http/RequestHandlers/PasteFact.php
index aa55658086..c2bce2ad72 100644
--- a/app/Http/RequestHandlers/PasteFact.php
+++ b/app/Http/RequestHandlers/PasteFact.php
@@ -28,6 +28,7 @@ use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Server\RequestHandlerInterface;
 
 use function assert;
+use function is_string;
 use function redirect;
 
 /**
@@ -60,11 +61,12 @@ class PasteFact implements RequestHandlerInterface
         $tree = $request->getAttribute('tree');
         assert($tree instanceof Tree);
 
-        $xref    = $request->getAttribute('xref');
+        $xref = $request->getAttribute('xref');
+        assert(is_string($xref));
+
         $fact_id = $request->getParsedBody()['fact_id'];
         $record  = GedcomRecord::getInstance($xref, $tree);
-
-        Auth::checkRecordAccess($record, true);
+        $record = Auth::checkRecordAccess($record, true);
 
         $this->clipboard_service->pasteFact($fact_id, $record);