Use Validator

1 files changed, 64 insertions, 19 deletions

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
index 28a555d616..ce1195f1be 100644
--- a/phpstan-baseline.neon
+++ b/phpstan-baseline.neon
@@ -626,6 +626,16 @@ parameters:
 			path: app/Http/RequestHandlers/CreateRepositoryAction.php
 
 		-
+			message: "#^Parameter \\#1 \\$str of function trim expects string, string\\|null given\\.$#"
+			count: 6
+			path: app/Http/RequestHandlers/CreateSourceAction.php
+
+		-
+			message: "#^Parameter \\#1 \\$str of function trim expects string, string\\|null given\\.$#"
+			count: 1
+			path: app/Http/RequestHandlers/CreateSubmitterAction.php
+
+		-
 			message: "#^Cannot access property \\$xref on mixed\\.$#"
 			count: 2
 			path: app/Http/RequestHandlers/DataFixUpdateAll.php
@@ -646,6 +656,11 @@ parameters:
 			path: app/Http/RequestHandlers/DeleteUser.php
 
 		-
+			message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#"
+			count: 1
+			path: app/Http/RequestHandlers/EditFactAction.php
+
+		-
 			message: "#^Parameter \\#2 \\$gedcom of method Fisharebest\\\\Webtrees\\\\GedcomRecord\\:\\:updateFact\\(\\) expects string, string\\|null given\\.$#"
 			count: 1
 			path: app/Http/RequestHandlers/EditFactAction.php
@@ -676,11 +691,26 @@ parameters:
 			path: app/Http/RequestHandlers/EditMediaFileAction.php
 
 		-
+			message: "#^Parameter \\#1 \\$str of function trim expects string, string\\|null given\\.$#"
+			count: 2
+			path: app/Http/RequestHandlers/EditMediaFileAction.php
+
+		-
 			message: "#^Parameter \\#1 \\$gedcom of method Fisharebest\\\\Webtrees\\\\GedcomRecord\\:\\:updateRecord\\(\\) expects string, string\\|null given\\.$#"
 			count: 1
 			path: app/Http/RequestHandlers/EditNoteAction.php
 
 		-
+			message: "#^Parameter \\#1 \\$str of function trim expects string, string\\|null given\\.$#"
+			count: 1
+			path: app/Http/RequestHandlers/EditRawFactAction.php
+
+		-
+			message: "#^Parameter \\#1 \\$str of function trim expects string, string\\|null given\\.$#"
+			count: 1
+			path: app/Http/RequestHandlers/EditRawRecordAction.php
+
+		-
 			message: "#^Parameter \\#1 \\$content of function response expects array\\|object\\|string, string\\|false given\\.$#"
 			count: 1
 			path: app/Http/RequestHandlers/FaviconIco.php
@@ -821,6 +851,11 @@ parameters:
 			path: app/Http/RequestHandlers/ManageMediaData.php
 
 		-
+			message: "#^Parameter \\#2 \\$default of method Fisharebest\\\\Webtrees\\\\Validator\\:\\:string\\(\\) expects string\\|null, mixed given\\.$#"
+			count: 1
+			path: app/Http/RequestHandlers/ManageMediaPage.php
+
+		-
 			message: "#^Cannot cast mixed to int\\.$#"
 			count: 1
 			path: app/Http/RequestHandlers/MapDataAdd.php
@@ -1151,6 +1186,11 @@ parameters:
 			path: app/Http/RequestHandlers/TreePageBlock.php
 
 		-
+			message: "#^Parameter \\#1 \\$str of function trim expects string, string\\|null given\\.$#"
+			count: 1
+			path: app/Http/RequestHandlers/TreePreferencesAction.php
+
+		-
 			message: "#^Cannot access property \\$l_from on mixed\\.$#"
 			count: 2
 			path: app/Http/RequestHandlers/UnconnectedPage.php
@@ -1261,9 +1301,9 @@ parameters:
 			path: app/Module/AbstractModule.php
 
 		-
-			message: "#^Cannot cast mixed to string\\.$#"
+			message: "#^Argument of an invalid type array\\|string supplied for foreach, only iterables are supported\\.$#"
 			count: 1
-			path: app/Module/BranchesListModule.php
+			path: app/Module/CensusAssistantModule.php
 
 		-
 			message: "#^Call to an undefined method object\\:\\:censusLanguage\\(\\)\\.$#"
@@ -1276,6 +1316,11 @@ parameters:
 			path: app/Module/CensusAssistantModule.php
 
 		-
+			message: "#^Empty array passed to foreach\\.$#"
+			count: 1
+			path: app/Module/CensusAssistantModule.php
+
+		-
 			message: "#^Parameter \\#1 \\$census of method Fisharebest\\\\Webtrees\\\\Module\\\\CensusAssistantModule\\:\\:censusTableEmptyRow\\(\\) expects Fisharebest\\\\Webtrees\\\\Census\\\\CensusInterface, object given\\.$#"
 			count: 1
 			path: app/Module/CensusAssistantModule.php
@@ -1296,6 +1341,11 @@ parameters:
 			path: app/Module/CensusAssistantModule.php
 
 		-
+			message: "#^Parameter \\#5 \\$ca_individuals of method Fisharebest\\\\Webtrees\\\\Module\\\\CensusAssistantModule\\:\\:createNoteText\\(\\) expects array\\<array\\<string\\>\\>, array\\<string\\> given\\.$#"
+			count: 1
+			path: app/Module/CensusAssistantModule.php
+
+		-
 			message: "#^Call to an undefined method Fisharebest\\\\Webtrees\\\\Module\\\\ModuleInterface\\:\\:chartBoxMenu\\(\\)\\.$#"
 			count: 1
 			path: app/Module/CloudsTheme.php
@@ -1532,7 +1582,7 @@ parameters:
 
 		-
 			message: "#^Cannot cast mixed to int\\.$#"
-			count: 1
+			count: 3
 			path: app/Module/FrequentlyAskedQuestionsModule.php
 
 		-
@@ -1541,11 +1591,6 @@ parameters:
 			path: app/Module/GeonamesAutocomplete.php
 
 		-
-			message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
-			count: 1
-			path: app/Module/GeonamesAutocomplete.php
-
-		-
 			message: "#^Cannot cast mixed to int\\.$#"
 			count: 2
 			path: app/Module/HitCountFooterModule.php
@@ -1636,11 +1681,6 @@ parameters:
 			path: app/Module/InteractiveTree/TreeView.php
 
 		-
-			message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
-			count: 1
-			path: app/Module/MapGeoLocationGeonames.php
-
-		-
 			message: "#^Method Fisharebest\\\\Webtrees\\\\Module\\\\MapGeoLocationGeonames\\:\\:extractLocationsFromResponse\\(\\) should return array\\<string\\> but returns mixed\\.$#"
 			count: 1
 			path: app/Module/MapGeoLocationGeonames.php
@@ -1651,11 +1691,6 @@ parameters:
 			path: app/Module/MapGeoLocationNominatim.php
 
 		-
-			message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
-			count: 1
-			path: app/Module/MapGeoLocationOpenRouteService.php
-
-		-
 			message: "#^Method Fisharebest\\\\Webtrees\\\\Module\\\\MapGeoLocationOpenRouteService\\:\\:extractLocationsFromResponse\\(\\) should return array\\<string\\> but returns mixed\\.$#"
 			count: 1
 			path: app/Module/MapGeoLocationOpenRouteService.php
@@ -1801,7 +1836,7 @@ parameters:
 			path: app/Module/SlideShowModule.php
 
 		-
-			message: "#^Cannot call method getQueryParams\\(\\) on mixed\\.$#"
+			message: "#^Parameter \\#1 \\$request of static method Fisharebest\\\\Webtrees\\\\Validator\\:\\:queryParams\\(\\) expects Psr\\\\Http\\\\Message\\\\ServerRequestInterface, mixed given\\.$#"
 			count: 1
 			path: app/Module/SlideShowModule.php
 
@@ -2591,6 +2626,16 @@ parameters:
 			path: app/Services/ClipboardService.php
 
 		-
+			message: "#^Offset 'column' does not exist on string\\.$#"
+			count: 3
+			path: app/Services/DatatablesService.php
+
+		-
+			message: "#^Offset 'dir' does not exist on string\\.$#"
+			count: 2
+			path: app/Services/DatatablesService.php
+
+		-
 			message: "#^Method Fisharebest\\\\Webtrees\\\\Services\\\\GedcomEditService\\:\\:insertMissingRecordSubtags\\(\\) should return string but returns string\\|null\\.$#"
 			count: 2
 			path: app/Services/GedcomEditService.php