PHPdoc and PHPstan issues

7 files changed, 11 insertions, 14 deletions

diff --git a/tests/app/Http/Middleware/HandleExceptionsTest.php b/tests/app/Http/Middleware/HandleExceptionsTest.php
index de543c8037..f09ac13858 100644
--- a/tests/app/Http/Middleware/HandleExceptionsTest.php
+++ b/tests/app/Http/Middleware/HandleExceptionsTest.php
@@ -49,7 +49,7 @@ class HandleExceptionsTest extends TestCase
         Registry::container()->set(ModuleService::class, $module_service);
 
         $request    = self::createRequest();
-        $middleware = new HandleExceptions(php_service: new PhpService(), tree_service: $tree_service);
+        $middleware = new HandleExceptions(new PhpService(), $tree_service);
         $response   = $middleware->process($request, $handler);
 
         self::assertSame(StatusCodeInterface::STATUS_INTERNAL_SERVER_ERROR, $response->getStatusCode());
diff --git a/tests/app/Http/RequestHandlers/ControlPanelControllerTest.php b/tests/app/Http/RequestHandlers/ControlPanelControllerTest.php
index e43b0371af..233672c297 100644
--- a/tests/app/Http/RequestHandlers/ControlPanelControllerTest.php
+++ b/tests/app/Http/RequestHandlers/ControlPanelControllerTest.php
@@ -49,12 +49,12 @@ class ControlPanelControllerTest extends TestCase
         $server_check_service  = new ServerCheckService(php_service: new PhpService());
         $timeout_service       = new TimeoutService(php_service: new PhpService());
         $gedcom_import_service = new GedcomImportService();
-        $tree_service          = new TreeService(gedcom_import_service: $gedcom_import_service);
-        $upgrade_service       = new UpgradeService(timeout_service: $timeout_service);
+        $tree_service          = new TreeService($gedcom_import_service);
+        $upgrade_service       = new UpgradeService($timeout_service);
         $user_service          = new UserService();
         $handler               = new ControlPanel(
-            admin_service: $admin_service,
-            housekeeping_service: $housekeeping_service,
+            $admin_service,
+            $housekeeping_service,
             message_service:  $message_service,
             module_service:  $module_service,
             server_check_service:  $server_check_service,
@@ -63,7 +63,7 @@ class ControlPanelControllerTest extends TestCase
             user_service:  $user_service,
         );
         $request               = self::createRequest();
-        $response              = $handler->handle(request: $request);
+        $response              = $handler->handle($request);
 
         self::assertSame(StatusCodeInterface::STATUS_OK, $response->getStatusCode());
     }
diff --git a/tests/app/Http/RequestHandlers/DataFixDataTest.php b/tests/app/Http/RequestHandlers/DataFixDataTest.php
index f78eef7aee..ebf25de936 100644
--- a/tests/app/Http/RequestHandlers/DataFixDataTest.php
+++ b/tests/app/Http/RequestHandlers/DataFixDataTest.php
@@ -37,9 +37,6 @@ class DataFixDataTest extends TestCase
 {
     protected static bool $uses_database = true;
 
-    /**
-     * Test request handler
-     */
     public function testHandlerForFixSearchAndReplace(): void
     {
         $gedcom_import_service = new GedcomImportService();
diff --git a/tests/app/Http/RequestHandlers/ManageMediaPageTest.php b/tests/app/Http/RequestHandlers/ManageMediaPageTest.php
index 6f3417dde5..daa626ac8a 100644
--- a/tests/app/Http/RequestHandlers/ManageMediaPageTest.php
+++ b/tests/app/Http/RequestHandlers/ManageMediaPageTest.php
@@ -33,7 +33,7 @@ class ManageMediaPageTest extends TestCase
     public function testIndex(): void
     {
         $media_file_service = new MediaFileService(php_service: new PhpService());
-        $handler            = new ManageMediaPage(media_file_service: $media_file_service);
+        $handler            = new ManageMediaPage($media_file_service);
         $request            = self::createRequest();
         $response           = $handler->handle($request);
 
diff --git a/tests/app/Http/RequestHandlers/RedirectModulePhpTest.php b/tests/app/Http/RequestHandlers/RedirectModulePhpTest.php
index b369749007..deb1505d46 100644
--- a/tests/app/Http/RequestHandlers/RedirectModulePhpTest.php
+++ b/tests/app/Http/RequestHandlers/RedirectModulePhpTest.php
@@ -73,7 +73,7 @@ class RedirectModulePhpTest extends TestCase
         $module_service = $this->createMock(ModuleService::class);
         $module_service
             ->expects($this->once())
-            ->method('findByinterface')
+            ->method('findByInterface')
             ->with(PedigreeMapModule::class)
             ->willReturn(new Collection([$module]));
 
diff --git a/tests/app/Http/RequestHandlers/UploadMediaActionTest.php b/tests/app/Http/RequestHandlers/UploadMediaActionTest.php
index 251209a400..9c8309d149 100644
--- a/tests/app/Http/RequestHandlers/UploadMediaActionTest.php
+++ b/tests/app/Http/RequestHandlers/UploadMediaActionTest.php
@@ -33,7 +33,7 @@ class UploadMediaActionTest extends TestCase
     public function testResponseIsOK(): void
     {
         $media_file_service = new MediaFileService(php_service: new PhpService());
-        $handler            = new UploadMediaAction(media_file_service: $media_file_service);
+        $handler            = new UploadMediaAction($media_file_service);
         $request            = self::createRequest();
         $response           = $handler->handle($request);
 
diff --git a/tests/app/Http/RequestHandlers/UploadMediaPageTest.php b/tests/app/Http/RequestHandlers/UploadMediaPageTest.php
index 7f257e30d7..fbd4013763 100644
--- a/tests/app/Http/RequestHandlers/UploadMediaPageTest.php
+++ b/tests/app/Http/RequestHandlers/UploadMediaPageTest.php
@@ -33,8 +33,8 @@ class UploadMediaPageTest extends TestCase
     public function testResponseIsOK(): void
     {
         $php_service        = new PhpService();
-        $media_file_service = new MediaFileService(php_service: $php_service);
-        $handler            = new UploadMediaPage(media_file_service: $media_file_service, php_service: $php_service);
+        $media_file_service = new MediaFileService($php_service);
+        $handler            = new UploadMediaPage($media_file_service, $php_service);
         $request            = self::createRequest();
         $response           = $handler->handle($request);