Rename resolver functions to be laravel-like and add tests

1 files changed, 110 insertions, 0 deletions

diff --git a/tests/feature/ModuleRoutingandResolvingTest.php b/tests/feature/ModuleRoutingandResolvingTest.php
new file mode 100644
index 0000000000..c2e1c9a9fa
--- /dev/null
+++ b/tests/feature/ModuleRoutingandResolvingTest.php
@@ -0,0 +1,110 @@
+<?php
+/**
+ * webtrees: online genealogy
+ * Copyright (C) 2019 webtrees development team
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+declare(strict_types=1);
+
+namespace Fisharebest\Webtrees\Http\Controllers;
+
+use Fisharebest\Webtrees\Auth;
+use Fisharebest\Webtrees\Resolver;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+/**
+ * Test the module controller
+ *
+ * @covers \Fisharebest\Webtrees\Http\Controllers\ModuleController
+ */
+class ModuleRoutingTest extends \Fisharebest\Webtrees\TestCase
+{
+    protected static $uses_database = true;
+
+    /**
+     * @expectedException \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
+     * @return void
+     */
+    public function testMissingModule(): void
+    {
+        $user       = Auth::user();
+        $controller = new ModuleController();
+        $request    = new Request(['route' => 'module']);
+        $controller->action($request, $user, new Resolver());
+    }
+
+    /**
+     * @expectedException \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
+     * @return void
+     */
+    public function testInvalidModule(): void
+    {
+        $user       = Auth::user();
+        $controller = new ModuleController();
+        $request    = new Request(['route' => 'module', 'module' => 'no-such-module']);
+        $controller->action($request, $user, new Resolver());
+    }
+
+    /**
+     * @expectedException \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
+     * @return void
+     */
+    public function testMissingAction(): void
+    {
+        $user       = Auth::user();
+        $controller = new ModuleController();
+        $request    = new Request(['route' => 'module', 'module' => 'sitemap']);
+        $controller->action($request, $user, new Resolver());
+    }
+
+    /**
+     * @expectedException \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
+     * @return void
+     */
+    public function testInvalidAction(): void
+    {
+        $user       = Auth::user();
+        $controller = new ModuleController();
+        $request    = new Request(['route' => 'module', 'module' => 'sitemap', 'action' => 'no-such-action']);
+        $controller->action($request, $user, new Resolver());
+    }
+
+    /**
+     * @expectedException \Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException
+     * @return void
+     */
+    public function testVisitorCannotUseAdminAction(): void
+    {
+        //$tree = $this->importTree('demo.ged');
+        $user = Auth::user();
+
+        $controller = new ModuleController();
+
+        $request = new Request(['route' => 'module', 'module' => 'sitemap', 'action' => 'DoAdminStuff']);
+        //Theme::theme(new WebtreesTheme())->init(new Request, $tree);
+        $controller->action($request, $user, new Resolver());
+    }
+
+    /**
+     * @return void
+     */
+    public function testSucessfulAction(): void
+    {
+        $user       = Auth::user();
+        $controller = new ModuleController();
+        $request    = new Request(['route' => 'module', 'module' => 'sitemap', 'action' => 'Index']);
+        $response   = $controller->action($request, $user, new Resolver());
+
+        $this->assertInstanceOf(Response::class, $response);
+    }
+}