diff options
| -rw-r--r-- | app/Contracts/IdFactoryInterface.php | 2 | ||||
| -rw-r--r-- | app/Factories/IdFactory.php | 2 | ||||
| -rw-r--r-- | app/Http/RequestHandlers/AutoCompleteFolder.php | 3 | ||||
| -rw-r--r-- | app/Services/GedcomExportService.php | 14 | ||||
| -rw-r--r-- | tests/app/Services/GedcomEditServiceTest.php | 2 | ||||
| -rw-r--r-- | tests/views/AbstractViewTest.php | 4 |
6 files changed, 16 insertions, 11 deletions
diff --git a/app/Contracts/IdFactoryInterface.php b/app/Contracts/IdFactoryInterface.php index 7551ffe808..7c095413f2 100644 --- a/app/Contracts/IdFactoryInterface.php +++ b/app/Contracts/IdFactoryInterface.php @@ -32,6 +32,8 @@ interface IdFactoryInterface /** * An identifier for use in CSS/HTML * + * @param string $prefix + * * @return string */ public function id(string $prefix = 'id-'): string; diff --git a/app/Factories/IdFactory.php b/app/Factories/IdFactory.php index 1ee70a5754..a9a902d522 100644 --- a/app/Factories/IdFactory.php +++ b/app/Factories/IdFactory.php @@ -52,6 +52,8 @@ class IdFactory implements IdFactoryInterface /** * An identifier for use in CSS/HTML * + * @param string $prefix + * * @return string */ public function id(string $prefix = 'id-'): string diff --git a/app/Http/RequestHandlers/AutoCompleteFolder.php b/app/Http/RequestHandlers/AutoCompleteFolder.php index 6535cb9089..3cf2b67bef 100644 --- a/app/Http/RequestHandlers/AutoCompleteFolder.php +++ b/app/Http/RequestHandlers/AutoCompleteFolder.php @@ -35,7 +35,8 @@ class AutoCompleteFolder extends AbstractAutocompleteHandler private MediaFileService $media_file_service; /** - * @param SearchService $search_service + * @param MediaFileService $media_file_service + * @param SearchService $search_service */ public function __construct(MediaFileService $media_file_service, SearchService $search_service) { diff --git a/app/Services/GedcomExportService.php b/app/Services/GedcomExportService.php index 30bff398e3..fe47c516cf 100644 --- a/app/Services/GedcomExportService.php +++ b/app/Services/GedcomExportService.php @@ -94,12 +94,14 @@ class GedcomExportService } /** - * @param Tree $tree - Export data from this tree - * @param bool $sort_by_xref - Write GEDCOM records in XREF order - * @param string $encoding - Convert from UTF-8 to other encoding - * @param string $privacy - Filter records by role - * @param string $filename - Name of download file, without an extension - * @param string $format - One of: gedcom, zip, zipmedia, gedzip + * @param Tree $tree - Export data from this tree + * @param bool $sort_by_xref - Write GEDCOM records in XREF order + * @param string $encoding - Convert from UTF-8 to other encoding + * @param string $privacy - Filter records by role + * @param string $line_endings + * @param string $filename - Name of download file, without an extension + * @param string $format - One of: gedcom, zip, zipmedia, gedzip + * @param Collection|null $records * * @return ResponseInterface */ diff --git a/tests/app/Services/GedcomEditServiceTest.php b/tests/app/Services/GedcomEditServiceTest.php index 6234e78872..f90527b896 100644 --- a/tests/app/Services/GedcomEditServiceTest.php +++ b/tests/app/Services/GedcomEditServiceTest.php @@ -127,7 +127,6 @@ class GedcomEditServiceTest extends TestCase $new_facts = $gedcom_edit_service->newFamilyFacts($tree); self::assertSameSize($expected_new_facts, $new_facts); for ($i = 0; $i < count($expected_new_facts); $i++) { - /** @var \Fisharebest\Webtrees\Fact $new_fact */ $new_fact = $new_facts->get($i); self::assertSame($expected_new_facts[$i], $new_fact->tag()); } @@ -155,7 +154,6 @@ class GedcomEditServiceTest extends TestCase $new_facts = $gedcom_edit_service->newIndividualFacts($tree, $sex, $names); self::assertSameSize($expected_new_facts, $new_facts); for ($i = 0; $i < count($expected_new_facts); $i++) { - /** @var \Fisharebest\Webtrees\Fact $new_fact */ $new_fact = $new_facts->get($i); self::assertSame($expected_new_facts[$i], $new_fact->tag()); } diff --git a/tests/views/AbstractViewTest.php b/tests/views/AbstractViewTest.php index 939d2f82cc..f4f438e579 100644 --- a/tests/views/AbstractViewTest.php +++ b/tests/views/AbstractViewTest.php @@ -36,7 +36,7 @@ abstract class AbstractViewTest extends TestCase * Check the view runs without error and generates valid HTML * * @param string $view - * @param array<array<string,array<string,mixed>> $data + * @param array<array<string,array<string,mixed>>> $data */ protected function doTestView(string $view, array $data): void { @@ -50,7 +50,7 @@ abstract class AbstractViewTest extends TestCase /** * @param array<string,array<string,mixed>> $input * - * @return array<array<string,array<string,mixed>> + * @return array<array<string,array<string,mixed>>> */ private function cartesian(array $input): array { |