diff options
| author | Lester Caine <lester@lsces.co.uk> | 2026-06-08 20:56:16 +0100 |
|---|---|---|
| committer | Lester Caine <lester@lsces.co.uk> | 2026-06-08 20:56:16 +0100 |
| commit | 0b4a0fe697dac8eb32f02ff157193ee8feee6ade (patch) | |
| tree | 38225ea824c890f44a59def25a4c552ae8c9144d | |
| parent | 83a49c006d3bb0d9e84ff5068d6d9c1478fe73cf (diff) | |
| download | liberty-0b4a0fe697dac8eb32f02ff157193ee8feee6ade.tar.gz liberty-0b4a0fe697dac8eb32f02ff157193ee8feee6ade.tar.bz2 liberty-0b4a0fe697dac8eb32f02ff157193ee8feee6ade.zip | |
LibertyXref: guard xorder against null when item not in liberty_xref_item
(int) cast on $next prevents NULL overwriting the default xorder=0 when
fAddXref is used for an item type that has no liberty_xref_item row.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| -rw-r--r-- | includes/classes/LibertyXref.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/includes/classes/LibertyXref.php b/includes/classes/LibertyXref.php index 4ba8145..d35586c 100644 --- a/includes/classes/LibertyXref.php +++ b/includes/classes/LibertyXref.php @@ -145,7 +145,7 @@ class LibertyXref extends LibertyBase { $sql = "SELECT COALESCE( MAX(x.`xorder`) + 1, 1 ) FROM `".BIT_DB_PREFIX."liberty_xref` x WHERE x.`content_id` = ? AND x.`item` = ?"; $next = $this->mDb->getOne( $sql, [ $pParamHash['xref_store']['content_id'], $pParamHash['xref_store']['item'] ] ); } - $pParamHash['xref_store']['xorder'] = $next; + $pParamHash['xref_store']['xorder'] = (int)$next; } if( isset( $pParamHash['fStepXref'] ) ) { |